On 12/15/11 06:41, Rich Burridge wrote:
Hi,
Could I please get a code review for my fix for:
7117296 legacy actions need some love
http://monaco.us.oracle.com/detail.jsf?cr=7117296
Webrev is at:
http://jurassic.us.oracle.com/~richb/7117296-v1/
It's another big one, but very straight forward.
It might be easier to review by saving a copy of
http://jurassic.us.oracle.com/~richb/7117296-v1/7117296.patch
and then viewing the results in a text editor that does diff
colorisation.
Looks good to me.
I'm assuming you found the right subset to nuke and have not gone
back to double-check your selection, though from memory, it does seem
to only include packages which I think were added in S11 and never
found in S10. (The most notable execption is unzip, which was in
S10, but was part of SUNWswmt with the SVR4 patch tools, and since
we're not shipping most of that package, not including the legacy info
makes sense.)
I do wonder why apr-13-doc is not just delivered as the doc facet
of apr-13, but that's not this bug.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
