On 01/31/12 11:54, Danek Duvall wrote:
Ali Bahrami wrote:
It's a bit hard to evaluate the changes to os_unix.c from the
patch diffs. Are there before/after copies of os_unix.c online
anywhere so that the surrounding code context can be seen?
I've updated the webrev to include a wdiff of os_unix.c before and after.
If you want the raw files, let me know.
Thanks,
Danek
No, that's fine. Here's what I get out of reading these diffs:
- vim treats acls as a generic blob (vim_acl_T).
- A given platform supplies the best ACL style it
can muster, casting it to/from the generic pointer
type used by vim.
- Your changes appear to add support for the nfsv4/zfs style
of ACL, providing get/set/free operations.
It all seems fine. It's nice that the abstraction maps so directly
to the real operations. I trust that you set some ACLs on a test file
and verified that vim seems to honor them?
+1, unless I'm off base with the above.
- Ali
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
