Looks good to me though I am not familiar with PKGMOGRIFY_TRANSFORMS.
Thanks for taking care of gcc-45, George On 2/7/2012 3:49 PM, Rich Burridge wrote:
Hi all, Could I please get a code review for the changes for: 7079363 gcc-3.p5m package manifest file shouldn't deliver .la files http://monaco.us.oracle.com/detail.jsf?cr=7079363 7143056 Userland consolidation should remove .la files and warn/error against new ones http://monaco.us.oracle.com/detail.jsf?cr=7143056 Webrev is at: http://jurassic.us.oracle.com/~richb/7079363-7143056-v1/ The diffs make the following changes: * Remove all the .la files from all the component .p5m files. * Add a PKGMOGRIFY_TRANSFORMS line for .../transforms/libtool-drop to .../make-rules/ips.mk. * Removed the PKGMOGRIFY_TRANSFORMS line from .../graphviz/Makefile Workspace is at: /net/wonderland.us.oracle.com/builds/richb/7079363-7143056/ (Publish transcripts in the 'publish-trans.txt' file in each component directory that was rebuilt). I first of all just added the PKGMOGRIFY_TRANSFORMS line for .../transforms/libtool-drop to .../make-rules/ips.mk, and then built ghostscript and made sure that the .la file (which was still present in the .p5m file) was removed from the published package manifest. I then removed all the .la files from the .p5m files and successfully built each of the components that were changed (autogen, gcc3, gcc45, graphviz, guile and ghostscript). See the Bugster CR's for more details. Thanks. _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
