Hi Rich,
Your new changes look fine to me.
Thanks,
April
On 03/ 2/12 11:57 AM, Rich Burridge wrote:
Hi April,
components/nose/nose-26.p5m:
101 # force a dependency on the ply package
102 depend
fmri=library/python-2/nose@$(IPS_COMPONENT_VERSION),$(BUILD_VERSION) \
103 type=require
components/nose/nose-27.p5m:
100 # force a dependency on the ply package
For comments in each file on line 100 & line 101, change "ply" to
"nose".
Indeed. Stupid c&p error.
The rest looks fine.
New webrev with just those two changes at:
http://jurassic.us.oracle.com/~richb/7098136-v2/
Thanks.
On 02/27/12 05:39 AM, Rich Burridge wrote:
Hi all,
Could I please get a code review for the changes for:
7098136 Integrate python-nose into Userland
http://monaco.us.oracle.com/detail.jsf?cr=7098136
Webrev is at:
http://jurassic.us.oracle.com/~richb/7098136-v1/
x86 workspace is at:
/net/stard.us.oracle.com/tank/ws/UL/7098136/
Build log is:
/net/stard.us.oracle.com/tank/ws/UL/7098136/component/nose/publish-trans.txt
See the test related Comment in the Bugster CR for how I tested this.
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
