Thanks, Craig!
April

On 03/ 7/12 03:20 PM, Craig Mohrman wrote:
Looks good April.
craig

----- [email protected] wrote:

On 03/ 7/12 02:56 PM, Craig Mohrman wrote:
components/pcre/pcre.p5m
       72 file path=usr/lib/$(MACH64)/pkgconfig/libpcrecpp.pc
       73 file path=usr/lib/$(MACH64)/pkgconfig/libpcrecpp.pc
     Looks like redundant entries.
Thanks for catching this, Craig.  I've removed the extra entry.

Webrev showing diffs:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/pcre-upgrade/webrev-2-diffs/

Full webrev:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/pcre-upgrade/webrev-2/

Thanks for the review!
April

The rest looks fine.

craig


----- [email protected] wrote:

Argggh...sorry, here is the webrev:


http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/pcre-upgrade/webrev-1/

On 03/ 7/12 12:35 PM, Craig Mohrman wrote:
April,

You forgot a URL to your webrev.

----- [email protected] wrote:

Could I please get a code review for my update of pcre to v8.21?
The ARC case is still under review but there have been no issues
so
far,
and it times out on 3/12.

PSARC/2012/081 Update pcre to v8.21
http://psarc/Archives/CaseLog/arc/PSARC/2012/081

6960343 Upgrade PCRE to 8.10 or higher
http://monaco.us.oracle.com/detail.jsf?cr=6960343

6594265 man page for pcregrep is missing "Last Change:" date
http://monaco.us.oracle.com/detail.jsf?cr=6594265

Thanks,
April
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to