On 03/07/12 20:52, Rich Burridge wrote:
Hi all,
Could I please get a code review for:
7101897 libtool contains some automount paths
http://monaco.us.oracle.com/detail.jsf?cr=7101897
Webrev is at:
http://jurassic.sfbay/~richb/7101897-v1/
Userland workspace (with just libtool built) is at:
/net/stard.us.oracle.com/tank/ws/UL/7101897/
Build/publish log is at:
/net/stard.us.oracle.com/tank/ws/UL/7101897/components/libtool/publish-trans.txt
See the test related Comment in the Bugster CR for how I tested this.
(Thanks to alanc for help with this).
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
Hi Rich,
The fix is to substitute lines in libtool (a script file) once placed in PROTO
directories.
The substitution is to the whole lines that begin with 'LTCC="' or 'CC="'.
I'm interested as I know /usr/sbin/named also captures some pathnames. While
your fix won't help me it is food for thought.
Your changes look OK, I wonder though if a targeted replacement that allowed for
characters after the pathname would be more future proof? For example
$ echo 'CC="/some/path/to/cc" # comment' > test
$ echo 'XX="XX" # comment' >> test
$ /usr/gnu/bin/sed -e 's|^CC="[^"]*|CC="cc|' test
CC="cc" # comment
XX="XX" # comment
$
Regards, Stacey
--
-- Stacey Marshall
Solaris Software, Revenue Product Engineering. UK.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
