Looks fine Kevin. craig ----- [email protected] wrote:
> Craig, Petr, > > One last thumbs up/down from you guys? Only change from the last > webrev > is that I implemented Petr's suggestion with a slight difference: > Unless you $(UNPACK) -r into a sub-dir of $(PROTO_DIR) it fails in the > > tail end of userland-unpack script because the proto dir exists, > instead > of 'relocating-to' there I just cd'd there and unpacked it instead: > > latest diffs from gate: > http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-doxygen/webrev/ > > diffs from last webrev (highlights Petr's suggestion I implemented) > http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-doxygen/webrev.fixes-2/ > > Thanks for your patience on this one, > Kevin. > > > On 03/ 8/12 10:06 AM, Petr Sumbera wrote: > > Hi Kevin, > > > > I believe you could make it more simple with something like this: > > > > install: $(INSTALL_32) > > $(UNPACK) -r $(PROTO_DIR) $(COMPONENT_ARCHIVE_1) > > > > But I will leave it up to you. Otherwise it looks good. > > > > Thanks, > > > > Petr > > > > On 03/ 8/12 03:26 PM, Kevin Crowe wrote: > >> Hey Craig, Petr, > >> > >> I incorporated the feedback from both of you regarding downloading > the > >> documentation instead of checking it into the gate and using > >> IPS_COMPONENT_VERSION in the package manifest. Looking for a > re-review: > >> > >> latest diffs: > >> > http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-doxygen/webrev/ > > >> > >> > >> > >> diffs from original (easier to see updates to Makefile & .p5m for > >> downloading manual & IPS_COMPONENT_VERSION changes): > >> > http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-doxygen/webrev.fixes-1/ > > >> > >> > >> > >> original: > >> > http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-doxygen/webrev.orig/ > > >> > >> > >> > >> > >> Thanks, > >> Kevin. > >> > >> > >> On 03/ 2/12 03:36 PM, Kevin Crowe wrote: > >>> Hello, > >>> > >>> Looking for a review of CR 7135985 to upgrade Doxygen from 1.5.7.1 > to > >>> 1.7.6.1 > >>> > >>> > http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-doxygen/webrev/ > > >>> > >>> > >>> > >>> I'm still a few days away from RTI as I'm contacting desktop test > >>> folks but I do not anticipate any changes. If anyone is aware of > any > >>> other groups or people that should be notified of this change > please > >>> let me know so I may coordinate with them. > >>> > >>> Thanks, > >>> Kevin. > >>> > >>> _______________________________________________ > >>> userland-discuss mailing list > >>> [email protected] > >>> http://mail.opensolaris.org/mailman/listinfo/userland-discuss > >> > > _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
