Thanks, Rich!
April
On 03/22/12 06:14 AM, Rich Burridge wrote:
On 03/21/2012 05:13 PM, April Chin wrote:
On 03/21/12 05:11 PM, April Chin wrote:
Could I please get a code review for this small patch to pcre v8.21?
7155807 pcre v8.21 has a bug in fixed-length calculation for
lookbehinds
http://monaco.us.oracle.com/detail.jsf?cr=7155807
Disclaimer: I don't know the pcre code, but ...
The upstream bug report mentioned in the Bugster bug:
http://bugs.exim.org/show_bug.cgi?id=1187
provides a fix (and you've implemented that same patch), and there is
confirmation
in that bug report that the patch works, so if that's considered a
valid code review
then LGTM.
It was reported to me by a pcre community developer as a serious bug
in v8.21,
which was just upgraded in S11U1 build 12.
Webrev:
/net/jurassic.us.oracle.com/sfwcfi/builds/apchin/pcre-patch/webrev-1/
Correction:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/pcre-patch/webrev-1/
I've installed the new package on both x86 and sparc,
and, on a system with the new pcre package, built and (where
available) run the tests for
the 8 Userland components which have runtime dependencies on pcre.
Thanks,
April
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
