Hi Norm,
I'd like to continue with this code review, are you ok with the
explanation and a full version string used there? (I'm ready to replace
it if you think the short version string is better here).
Thank you
Petr
On 26.3.2012 8:31, Petr Cvachoucek wrote:
Hi Norm,
the idea why I used the full version string was to allow to run the
update not only when we uprev the gutenprint, but also if we just add a
patch to it (so the 5.2.7 version will not change, but rest of the
version string will).
$ pkg contents -H -a name=pkg.fmri -o value gutenprint | cut -d @ -f 2
5.2.7,5.11-0.175.1.0.0.11.711:20120305T172737Z
$ pkg info gutenprint | awk '/Version:/ {print $2}'
5.2.7
BTW, is there some better way how to obtain an installed package version
other than using awk/cut/... to parse it from pkg output? Something
which could be safely used in a script, without worry that pkg output
will change?
Thank you
Petr
On 23.3.2012 21:01, Norm Jacobs wrote:
svc-gutenprint-ppd-update:
line 22:
Don't you really want
VER=`pkg info $PKG | awk '/Version:/ {print $2}'`
So that you use the Gutenprint version and not the rest of the
release/branch/... cruft?
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
