On 04/ 6/12 09:43 AM, Rich Burridge wrote:
> Hi,
>
> Could I please get a code review for the changes for:
>
> 7159589 Adjust foomatic/fppd action to remove gzip -rf usage
> http://monaco.us.oracle.com/detail.jsf?cr=7159589
>
>
> Webrev is at:
>
> http://jurassic.us.oracle.com/~richb/7159589-v1/
Do you need to explicitly cd to the directory first? Can't you just do:
/usr/bin/find $(SOURCE_DIR)/share/ppd -name "*.ppd" -exec gzip {} +
And of course, there's also the question of if it makes sense to package the
files gzip'ed given current disk sizes and zfs filesystem-level support for
compression. In X, we stopped gzip'ing fonts because it wasn't saving enough
space to be worthwhile in most cases, and was instead wasting more space on the
live media & filesystem, since gzip shrinks files less than the other
compression methods used in those, and files that are already gzipped can't be
compressed as well as the raw files.
Looking at the output of:
find /usr/share/ppd -name '*.gz' -exec gzip -l {} + | less
it appears mostly you're shrinking files from 20k down to 3-4k, which is hardly
a big win on a terabyte hard disk.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
