Hi Srini,
Looks good.
Thanks,
April
On 04/13/12 01:54 PM, Srinivasa Sarva wrote:
April,
Thanks for the review.
comments inline...
Webrev diff
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/test/WORK_2/webrev-1/index.html
Updated Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/test/WORK_2/webrev/index.html
On 04/13/12 10:14, April Chin wrote:
Hi Srini,
components/junit/junit.license:
I don't know if you have a TPNO for junit to include here. You'll
also want to put in the
component name & version # at the top.
No TPNO yet. Added the name & version.
- Does the manpage components/junit/junit.3 need any changes for the
new version?
Added a new path.
components/junit/patches/build.xml.patch:
Are these changes just porting the patch to the new version of the
build.xml source,
or does this patch come from upstream? There are some changes which
aren't in
the old patch.
Just porting the patch to the new version and few changes to make
it build
with out issues.
7160524 Upgarde JUnit4.5 to 4.10
^^^^^^
also, a small typo in the bug synopsis
Corrected..
-Srini
April
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
