Hi Doug,
Copyright needs adjusting in Makefile but I'm sure hg will tell you that.
The license file is up to date (compared with LICENSE), I noticed that many
other license files include a header though which you may want to include to
identify oracle tracking number; the following one is from isc-dhcp:
$ head components/isc-dhcp/isc-dhcp.license
Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
-----------------------
- ISC DHCP 4.1-ESV-R4 -
-----------------------
Oracle Internal Tracking Number : 6913
# Copyright (c) 2004-2012 by Internet Systems Consortium, Inc. ("ISC")
# Copyright (c) 1995-2003 by Internet Software Consortium
Regards,
Stace
On 04/18/12 22:48, Doug Leavitt wrote:
I am looking for a code review for this update of openldap from 2.4.25 to
2.4.30.
The CR for the update is 7162280, but with the update CR 7106938 gets fixed
by virtue of having been fixed upstream between 2.4.25 and 2.4.30. Since the
components/openldap Makefile is changing I also added the corrections
mentioned in
CR 7150070 openldap is finding libnet again
that previously existed in SFW, but were lost in the move to userland.
In addition to the requisite library version number changes in the p5m file
I corrected the packaging to include usr/include/openldap/ldif.h which is a
header file that must be available if the libldap ldif functions are to be used.
It seems to have been missing for a while [even SFW] but should always have
been distributed.
The webrev is here:
http://jurassic.us.oracle.com/net/x4200m2-sfb-05/builds/dleavitt/7162280/userland/webrev/
For testing build on both x86 and sparc have been performed
and the make test has been re-run to verify that openldap's test suite
passes as expected (which it does).
Additionally the naming team is currently using this build as part of our
conversion
of the ON consolidation from Mozilla libldap to OpenLDAP. So far all builds
based
on this library are successfully booting, running LDAP naming services and
are currently undergoing thorough ON system and regression testing.
Finally, legal approvals to update from 2.4.25 to 2.4.30 have been received.
Thanks in advance,
Doug.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
--
-- Stacey Marshall
Solaris Software, Revenue Product Engineering. UK.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
