php 5.3.10 is being added alongside php 5.2.17.

I'm not quite through PSARC.  Some minor nits surrounding
the version control via an IPS mediator.  PSARC/2012/067
But as I'm trying to get this into B15, pretty please Mike hold the gate,
I want to get this review started now because it's big.

Here is the normal webrev:
http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_php-5_3_10/webrev/index.html

It's not very useful because most of the files are "new" while
in fact they are just tweaked copies of php5.2 files.
So I wrote a little script to compare these files directly
which should be helpful.

/home/cmohrman/php-cr
or
/net/hs-usca-01.sfbay/export/home1/12/cmohrman/php-cr

This uses a graphical diff tool, filemerge or meld, and a list of files
where you choose where to start.
You can interrupt the script at any point and start over.

If you want to use meld you'll need pkg:/developer/meld installed.
It's slightly nicer because it shows graphically where lines moved to
if not far away.

The script won't review all files yet because of file renames so
I'm working on a script for that now.

But this will keep someone busy for a while as is.

Many thanks to you brave soles who help review this.
craig
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to