LGTM, just one question:
By removing the patch to ${top_srcdir}/lib/Makefile.in, libcurl.so's
SONAME will change from libcurl.so.3 to libcurl.so.4:
[steleman@userland][/net/stard.us.oracle.com/tank/ws/UL/7161374/components/curl/build/prototype/i386/usr/lib][08/28/2012
16:16:30][568]>> pwd
/net/stard.us.oracle.com/tank/ws/UL/7161374/components/curl/build/prototype/i386/usr/lib
[steleman@userland][/net/stard.us.oracle.com/tank/ws/UL/7161374/components/curl/build/prototype/i386/usr/lib][08/28/2012
16:16:37][569]>> dump -Lv libcurl.so.4.2.0 | egrep SONAME
[20] SONAME libcurl.so.4
[steleman@userland][/net/stard.us.oracle.com/tank/ws/UL/7161374/components/curl/build/prototype/i386/usr/lib][08/28/2012
16:16:40][570]>> dump -Lv /usr/lib/libcurl.so.3.0.0 | egrep SONAME
[20] SONAME libcurl.so.3
[steleman@userland][/net/stard.us.oracle.com/tank/ws/UL/7161374/components/curl/build/prototype/i386/usr/lib][08/28/2012
16:16:47][571]>>
--Stefan
-----
Rich Burridge wrote:
Hi all,
Please can I get a code review for my changes for:
7161374 Update curl to the latest version
http://monaco.us.oracle.com/detail.jsf?cr=7161374
Webrev is at:
http://jurassic.us.oracle.com/~richb/7161374-v1/
My x86 workspace is at:
/net/stard.us.oracle.com/tank/ws/UL/7161374/
Build/publish log in:
/net/stard.us.oracle.com/tank/ws/UL/7161374/components/curl/publish-trans.txt
I also built it on the two Userland build machines:
Those build/publish logs are at:
x86:
/net/userland.us.oracle.com/builds/richb/7161374/components/curl/publish-trans.txt
SPARC:
/net/wonderland.us.oracle.com/builds/richb/7161374/components/curl/publish-trans.txt
As pkg is a heavy user of the web/curl package, Erik Trauschke in the
pkg team kindly tested my newly created packages (thanks!). The results
for both x86 and SPARC are included in a Bugster CR Comment.
Thanks.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
--
Stefan Teleman
Oracle USA Corporation
stefan.tele...@oracle.com
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
