Craig,
Thanks for the review. Comments below.
On 09/11/12 14:10, Craig Mohrman wrote:
components/lua/Makefile
So no tests anymore?
Yup, no tests available in this version.
components/lua/lua.p5m
Are the demos no longer provided or you're choosing to
not package them?
Do we have a policy around demos?
I would think we should keep them if not too large.
Yes, not provided anymore. I'll check the size.
Lot of Makefile patching.
It's troubling that lua hasn't learned how to build shared
libraries. That should be fed back to the community.
Can I see your build workspace please so I can
see the resulting Makefiles?
WS:
/home/srini/S11U2/WS1/components/lua
Thanks
Srini
Thanks,
craig
----- [email protected] wrote:
Craig,
When you have time, can you please review this?
-Srini
On 09/07/12 17:08, Srinivasa Sarva wrote:
Hi all,
Please review the changes for
7197062 Upgrade lua to 5.2.1
Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/S11U2/WS3/webrev/
Thanks
Srini
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
