Hi guys, Sorry I was not able to attend. > > Bug 2340 Update (djmitche, 16:37:19) > Turning on protected branches in Github (djmitche, 16:39:24) > > https://github.com/blog/2051-protected-branches-and-required-status-checks > (djmitche, 16:39:46) > proposal is to protect the 'master' and 'eight' branches, > requiring that travis / appveyor / circle all succeed for a PR to be merged > (djmitche, 16:43:10) > AGREED: everyone present seems to agree this is a good idea > (djmitche, 16:43:20) >
I don't disagree with that. I have been implementing that rule manually already. Please let me know if I hadn't. We had a travis regression last week, which was to my understanding due to a conflict between two PR. The code was mergeable, but the test introduced in one was not compatible with the code change introduced in the other one. We have a lot of activities those last few weeks. I hope we will continue on that trend with the forthcoming nine release. I try to merge the code as soon as possible with the rules (of thumb) as follow: - If the change is trivial enough and looks good to me, I just wait for travis and hit the merge button - If there is more debatable changes, I :+1: and wait for a few days so that other ppl have the time to review it. Please don't hesitate to help applying this process as well. Hit the review and merge buttons when you think it is appropriate! > mainstreaming buildbot_travis (djmitche, 16:44:50) > proposal is to move https://github.com/tardyp/buildbot_travis to > the buildbot org, and make it a buildbot product (djmitche, 16:49:30) > AGREED: will move buildbot_travis into the buildbot org (djmitche, > 16:50:17) > ACTION: tardyp to move buildbot_travis (djmitche, 16:50:33) > Done. jc2k has been very helpful at transferring the ownership of the original fork of buildbot_travis to the buildbot organisation. With this we can keep our SEO rank, fork list, and starlist, as github is setting up redirects as appropriate. https://github.com/buildbot/buildbot_travis
_______________________________________________ users mailing list users@buildbot.net https://lists.buildbot.net/mailman/listinfo/users