On Wed, Feb 11, 2009 at 11:19 AM, Rhett Sutphin <[email protected]>wrote:
> Hi Assaf, > > Specs really really help. A patch could look simple and trivial, maybe >> it's >> a one line fix, but writing the spec and then accepting the patch is more >> work than accepting a tested patch. >> > > I have a question about this: do you prefer tickets where the spec and fix > are in separate patches? I've been submitting them together because that's > how I work (write spec, run to ensure it fails, write fix, commit, build > patch from commit) but I can see where it might be easier to review them if > they are separate. I apply them separately, spec first, then fix, then commit. But I always apply patches one file at a time, and actually working with one patch file is easier, and at least once before avoided confusion. Assaf > > > Thanks, > Rhett > > > On Feb 11, 2009, at 10:57 AM, Assaf Arkin wrote: > > On Wed, Feb 11, 2009 at 2:37 AM, Ittay Dror <[email protected]> wrote: >> >> For some time now there's a low mailing list activity and no SVN activity >>> at all. Bugs are not fixed and no evident progress towards releasing >>> 1.3.4. >>> >>> >>> Is the project still active? Can I offer my assistance? >>> >> >> >> Can't speak for other people, but I'm a few weeks behind on everything, >> emails and JIRA issues included. >> >> We do need a 1.3.4 release, we have enough changes and URLs to update now >> that we're top-level project. >> >> I'm planning a sprint through all the open issues in the coming days, and >> as >> always, easy patches get priority just because they're easy :-) >> >> Specs really really help. A patch could look simple and trivial, maybe >> it's >> a one line fix, but writing the spec and then accepting the patch is more >> work than accepting a tested patch. >> >> If you can't figure out how to fix something, but can at least write a >> spec >> to prove it's broken, that's also enormously helpful. The fix may end up >> to >> be trivial to someone else, just by running the spec and looking at the >> stack trace. >> >> So spec as much as possible. >> >> Assaf >> >> >> >>> >>> >>> Ittay >>> >>> >>> >
