Hi Alex <..> > Sweet! You may also consider using the Eclipse compiler (ECJ) by default > by adding require 'buildr/java/ecj' to the top of the generated buildfile > for consistency between buildr/eclipse builds. > I agree that this is a worthwile goal. In fact it lost a few hours a couple of months ago, because I had to manually tweek the dependencies.yml generated by buildr4osgi to reorder two dependencies, which the ecj handled correctly where suns and openjdks generated errors.
Therefore I think this feature should be mentioned in the doc. Also I think there should be a possibility to choose the desired version, as http://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj offers quite a few ones. Or is there already a possibility to set a specific version? If yes, I think it should also be documented. I think that I will also check how to set the compile.options.target in the buildfile. I tried to add a require 'buildr/java/ecj' to my buildfile, but it didn't work as it choked saying: > Compliance level '1.4' is incompatible with target level '1.5'. A > compliance level '1.5' or better is required Do you know what this error is about and how I can avoid it? <..> > > I haven't really looked at the details so just some quick > superficial/cosmetic comments... > I will cleanup my code following your suggestions. But I will have two weeks of vacation and be mostly off line. > As Peter said. And if you intend to iterate quickly in the coming weeks, > it may be simpler to open a pull request on github (with a tracking branch) > and attach the resulting work to Jira only after you're done with > development and we're done with the reviewing. But either approaches > work fine. Is https://github.com/ngiger/buildr/tree/eclipse what you are looking for? If yes I will send you the pull request as soon as I have my code cleaned up. Thanks for the rewiew! Niklaus
