The fix looks correct to me.
On Friday, October 19, 2012 at 9:53 AM, Niklaus Giger wrote: > Hi Antoine > > I have pushed > https://github.com/ngiger/buildr4osgi/commit/16ab63c614ac166c0ed5123bfb871b4ec422fc39 > > as a workaround into my buildr4osgi fork. > > I splitted the work into two parts. First I do the stuff to get the java > sources compile with > > unless compile.target.nil? > > > > plugin.path('.').include compile.target, :as=>'.' > > plugin.path('.').include properties.target, :as=>'.' unless > > properties.target.nil? > > > > end > > > > then I add all jars or whatever files (except the bin subdirectory) using > > unless manifest["Bundle-ClassPath"].nil? || compile.target.nil? > > > > plugin.with :manifest=> manifest, :meta_inf=>meta_inf > > manifest["Bundle-ClassPath"].split(",").each do |entry| > > > > next if entry.eql?('bin') or entry.eql?('bin/') # skip this > > at this is the default output of an eclipse plugin.include > > project._(entry), :as=>entry > > > > end > > plugin.with [resources.target, p_r.target].compact > > > > else > > > > plugin.with [compile.target, resources.target, p_r.target, > > properties.target].compact > > > > end > > > > plugin.process_qualifier > > > > end > > > > But I am not sure whether I understood all the implications of my change. > Antoine, do you think this the correct? In any case I will contact you about > my proposals to fix the buildr4osgi problems. > > Best regards > > Niklaus > > > Hey guys, > > > > I tried to understand the problem over the week-end. I haven't touched this > > code in a while. > > I kept thinking about this, and I can't remember where Bundle-ClassPath > > entries had more than one entry. > > So I'm guessing this is an oversight from me. > > > > Niklaus, happy to give you more rights so you can merge in a fix and make > > it work for you - just cycling over the entries instead of picking the > > first one should do. > > > > Antoine > <..> > >
