FYI
On Wed, Jul 6, 2011 at 2:14 PM, Claus Ibsen <[email protected]> wrote: > Hi > > Yeah I am catching up on my mailbox :) > Just got back from an extended weekend, visiting family. > > Well spotted. I have corrected the source. > > The code comment was needed, at the time, we did not override the > entrySet() method. > But sine we implemented the entrySet() method, that code comment is > not longer valid. > And we can use the entry set when copying from one map to another. > > Thanks for having hawk eyes on the commit list :) > > > > On Wed, Jul 6, 2011 at 1:22 PM, <[email protected]> wrote: >> Hi Claus, >> >> I don't know if you've already seen my entry in the user-forum: >> >> http://camel.465427.n5.nabble.com/The-camel-s-ProducerTemplate-is-missing-td4553299.html >> >> But anyway, it's really nice to see you back in town. The reason why I write >> you is the following: >> >> I realized that today you reverted the changes caused by >> >> https://issues.apache.org/jira/browse/CAMEL-4167 >> >> There's also a pretty old revision (1137250) by cmueller as well which I >> can't follow in all points, for example in that revision LRUSoftCache has >> changed from: >> >> @Override >> public void putAll(Map<? extends K, ? extends V> map) { >> // do not use entrySet but copy one by one >> for (K key : map.keySet()) { >> put(key, map.get(key)); >> } >> } >> >> To: >> >> @Override >> public void putAll(Map<? extends K, ? extends V> map) { >> // do not use entrySet but copy one by one >> for (Map.Entry<? extends K, ? extends V> entry : map.entrySet()) { >> put(entry.getKey(), entry.getValue()); >> } >> } >> >> >> I can imagine that you had a good reason not to use Map.entrySet method, but >> that's now no more the case, and the comment 'do not use entrySet but copy >> one by one' is still there! And so on and so on... >> >> Apperently the revision 1137250 was because of: >> >> https://analysis.apache.org/drilldown/violations/37401?priority=CRITICAL >> >> Regards, Babak On Tue, Jul 5, 2011 at 3:51 PM, bvahdat <[email protected]> wrote: > Hi all, > > since couple of days one can easily realize that the Camel's main "Kick-Ass" > is missing, > you surely know who I'm taking about but to just make it clear I mean Claus > Ibsen! > > Does anybody know if he probably has left the Camel community (of course, > that would be > really horrible for the Apache Camel Community) or is he just on holiday or > occupied on a > Fusesource client's project? > > Regards, Babak > > -- > View this message in context: > http://camel.465427.n5.nabble.com/The-camel-s-ProducerTemplate-is-missing-tp4553299p4553299.html > Sent from the Camel - Users mailing list archive at Nabble.com. > -- Claus Ibsen ----------------- FuseSource Email: [email protected] Web: http://fusesource.com Twitter: davsclaus, fusenews Blog: http://davsclaus.blogspot.com/ Author of Camel in Action: http://www.manning.com/ibsen/
