On Sun, Aug 14, 2011 at 11:56 AM, bvahdat <babak.vah...@swissonline.ch> wrote: > Hi Claus, > > Thanks for applying the patch. > > Regarding what you already said by this discussion: > >> However as we just use it for testing, then we can take a short cut >> and possible remove the log4j in the pom.xml file. But for the >> examples we should not, as it can help show best practice to end >> users, that they can setup log4j dependency and control which version >> they want to use. > > IMHO I think even by examples the direct dependencies to log4j is obsolete > and should be removed (it gives a wrong feeling to the users, that they > should do it in the same way, which to me is NOT the best practice), as I > think the camel users can NOT control which version of log4j they want to > use IF they instruct camel to use log4j through a direct dependency to > slf4j-log4j12. The simple foo.zip example I provided before by this > dicussion proves this fact, see > > http://camel.465427.n5.nabble.com/Camel-freemarker-tp4693216p4695940.html > > I even think that the camel users should be sensibilized on WIKI or through > the README.txt of examples that a version clash of log4j could cause > problems. > > I have already a patch available on my workspace for the examples as well > and could reopen the ticket and provide that as well. >
No people should be able to pick and chose any log4j version they want to use, that is compatible with slf4j. There is no where on the slf4j website that states you must use log4j 1.1.x. In fact if you look in the javadoc for the log4j appender from sfl4j it indicate it adapts to the log4j version in use http://www.slf4j.org/api/org/slf4j/impl/Log4jLoggerAdapter.html See this FAQ as well http://www.slf4j.org/faq.html#requirements In fact slf4j-log4j12.jar indicate its using log4j 1.2.x version. In the slf4j 1.6.1 parent pom.xml file it indicate its using this version of log4j <log4j.version>1.2.16</log4j.version> http://search.maven.org/#artifactdetails%7Corg.slf4j%7Cslf4j-parent%7C1.6.1%7Cpom > Any idea? > > Regards, Babak > > > > -- > View this message in context: > http://camel.465427.n5.nabble.com/Camel-freemarker-tp4693216p4697863.html > Sent from the Camel - Users mailing list archive at Nabble.com. > -- Claus Ibsen ----------------- FuseSource Email: cib...@fusesource.com Web: http://fusesource.com Twitter: davsclaus, fusenews Blog: http://davsclaus.blogspot.com/ Author of Camel in Action: http://www.manning.com/ibsen/
