Hi Thanks Jesper for the reproducer. I got some time to look into this, and was able to fix the bug https://issues.apache.org/jira/browse/CAMEL-17095
On Wed, Oct 6, 2021 at 10:02 AM Claus Ibsen <claus.ib...@gmail.com> wrote: > > Hi > > In the camel-resilience4j component, you can find there where it setup > that bulkhead / timeout etc > > On Wed, Oct 6, 2021 at 8:43 AM Jesper Duelund Isaksen > <jesper.duelund.isak...@systematic.com.invalid> wrote: > > > > Hi again > > > > I will give it a shot creating a native Resilience4j API implementation > > example this week. > > > > If looking into the Camel source code, would you have a quick pointer to > > where to start? I haven't looked into the source code of Camel before. > > > > > > Kind regards > > Jesper Isaksen > > > > -----Original Message----- > > From: Claus Ibsen <claus.ib...@gmail.com> > > Sent: 4. oktober 2021 15:27 > > To: users@camel.apache.org > > Subject: Re: Resilience4j with Bulkhead and TimeLimiter > > > > CAUTION - External Mail > > > > On Mon, Oct 4, 2021 at 2:43 PM Jesper Duelund Isaksen > > <jesper.duelund.isak...@systematic.com.invalid> wrote: > > > > > > Hi Claus, > > > > > > Not quite. I am expecting a timeout and a timeout exception to be thrown > > > since the max wait duration is configured lower than the time it should > > > take for the mock to respond. So unexpectedly the request succeeds since > > > it seems the timeout configuration has no effect. > > > > > > Yes, weirdly enough I can simply disable the Bulkhead and the > > > java.util.concurrent.TimeoutException is thrown and available on the > > > exchange as expected since the mock responds too slowly. > > > > > > I haven't tried to create a Resilience4j-only test using this combination > > > of configurations, so this could perhaps be related to Resilience4j as > > > well? > > > > > > > Well it is interesting to know using the vanilla resilience4j apis/building > > blocks, how such use-case should be put together. > > It's API is a bit complex, and then combining that into Camel makes it more > > complex as well. > > > > If you are able to do so then that would be great. > > > > You are of course also welcome to dive into the camel source code in that > > component to see if you can spot a problem. > > Or build your example as an unit test for the camel component we can use > > for tracking this down, and for testing against regressions in the future. > > > > And you are welcome to create a JIRA > > > > > Kind regards > > > Jesper Isaksen > > > > > > -----Original Message----- > > > From: Claus Ibsen <claus.ib...@gmail.com> > > > Sent: 4. oktober 2021 13:43 > > > To: users@camel.apache.org > > > Subject: Re: Resilience4j with Bulkhead and TimeLimiter > > > > > > CAUTION - External Mail > > > > > > Hi > > > > > > So are you saying that calling this http endpoint causes a timeout, but > > > that timeout is not triggered in the Camel route so the exchange fails? > > > > > > And if you turn off bulkhead, then you see such timeout exception on the > > > exchange ? > > > > > > On Mon, Oct 4, 2021 at 1:13 PM Jesper Duelund Isaksen > > > <jesper.duelund.isak...@systematic.com.invalid> wrote: > > > > > > > > Hi Camel users, > > > > > > > > When declaring a Camel Route that uses Resilience4j as a circuit > > > > breaker, I am seeing an issue where configuring a timeout has no effect > > > > in case a Bulkhead is also configured. This happens even though the > > > > option CancelRunningFuture is set to true. > > > > I was wondering if this is unintended or unsupported use of the circuit > > > > breaker? It doesn't seem to be explicitly documented as such though. > > > > > > > > I've created an example project with the route configuration here: > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi > > > > th > > > > ub.com%2Fsys-jdi%2Fcamel-timeout-test%2Fblob%2Fmain%2Fsrc%2Fmain%2Fj > > > > av > > > > a%2Forg%2Fproject%2Ftest%2FWireMockRouteBuilder.java&data=04%7C0 > > > > 1% > > > > 7Cjesper.duelund.isaksen%40systematic.com%7C2a2ec16a0fdb4c4fabc408d9 > > > > 87 > > > > 2c26a1%7C7f6211b17c5c42778403c0ccbd7f0408%7C0%7C0%7C6376894459629897 > > > > 13 > > > > %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI > > > > 6I > > > > k1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MU86e2IFhU4HXBSloXRk2ldOZ7Bt% > > > > 2F > > > > cwv41oMrxH6rH0%3D&reserved=0 > > > > > > > > It seems to happen for both Apache Camel 3.11.2 and Apache Camel 3.12.0. > > > > > > > > Kind Regards > > > > Jesper Isaksen > > > > > > > > > > > > -- > > > Claus Ibsen > > > ----------------- > > > https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdavsc > > > laus.com%2F&data=04%7C01%7Cjesper.duelund.isaksen%40systematic.com > > > %7C3804b5518c914679b45a08d9873aa836%7C7f6211b17c5c42778403c0ccbd7f0408 > > > %7C0%7C0%7C637689508272534451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > > > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lO > > > EHC5To4CwbcWGgC4EGD%2FbQjDEoh2Verc8t9wP3%2Fdk%3D&reserved=0 > > > @davsclaus Camel in Action 2: > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww. > > > manning.com%2Fibsen2&data=04%7C01%7Cjesper.duelund.isaksen%40syste > > > matic.com%7C3804b5518c914679b45a08d9873aa836%7C7f6211b17c5c42778403c0c > > > cbd7f0408%7C0%7C0%7C637689508272534451%7CUnknown%7CTWFpbGZsb3d8eyJWIjo > > > iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000& > > > ;sdata=WnmkRSmZwrzqkflTtlLrstVosO%2FZMiM9XXhSeL8mfds%3D&reserved=0 > > > > > > > > -- > > Claus Ibsen > > ----------------- > > https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdavsclaus.com%2F&data=04%7C01%7Cjesper.duelund.isaksen%40systematic.com%7C3804b5518c914679b45a08d9873aa836%7C7f6211b17c5c42778403c0ccbd7f0408%7C0%7C0%7C637689508272534451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lOEHC5To4CwbcWGgC4EGD%2FbQjDEoh2Verc8t9wP3%2Fdk%3D&reserved=0 > > @davsclaus Camel in Action 2: > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.manning.com%2Fibsen2&data=04%7C01%7Cjesper.duelund.isaksen%40systematic.com%7C3804b5518c914679b45a08d9873aa836%7C7f6211b17c5c42778403c0ccbd7f0408%7C0%7C0%7C637689508272534451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=WnmkRSmZwrzqkflTtlLrstVosO%2FZMiM9XXhSeL8mfds%3D&reserved=0 > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 -- Claus Ibsen ----------------- http://davsclaus.com @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
