Hello, The PR looks good to me, I just would like to have more feedback from others (in particular, Otavio, the one writing the Resume API and the Kinesis adapter.
Il giorno sab 16 dic 2023 alle ore 13:26 Alphonse Bendt < alphonse.be...@gmail.com> ha scritto: > Hi folks, > > A couple of days ago, I asked about resuming an AWS kinesis stream > consumer: > > https://lists.apache.org/thread/sc6oks5jckcbj19t06chmfpm6dpwt60t > > I have experimented a bit more with the camel codebase and think now that > there is functionality missing to allow implementing a ResumeStrategy for a > Kinesis consumer: > > I think the consumer should make the shardId available, plus I think the > API of the KinesisResumeAdapter needs to be modified. > I have created a Branch with both proposed changes (see > https://github.com/apache/camel/pull/12462/files). > With these changes, I could sketch a custom ResumeStrategy (see branch). > > Is this something you would accept as a PR? > > Regards, > Alphonse > > > >
