Please find my answers inline Regards, Anshul
On 16-Sep-2015, at 1:53 PM, Daan Hoogland <daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com>> wrote: On Wed, Sep 16, 2015 at 10:17 AM, Anshul Gangwar <anshul.gang...@citrix.com<mailto:anshul.gang...@citrix.com>> wrote: Currently we report only PowerOn VMs and do not report PowerOff VMs that's why we consider Missing and PowerOff as same This is not the behavior reported in the ticket. It is intermittent. [Anshul] Your PR is changing this behaviour. It is intermittent because of the ping interval. And that's how most of the code is written for VM sync and each Hypervisor resource has same understanding. This will effect HA and many more unknown places. So please do not even consider to merge this change. sure, I will hold. We do need to not regard a missing report the same as power off however. [Anshul] Initially this was the case that PowerOff and PowerResportMissing states were different but later when many issues were reported in vmSync it makes more sense to consider PowerReportMissing and PowerOff as same. So if you are thinking of considering these states to be different then make sure you have considered all these scenarios and tested it on every Hypervisor that we support as each Hypervisor reports states according to this understanding. Kaushik can give a better understanding around this. So Now coming to bug we can fix that by changing global setting pingInterval to appropriate value according to hypervisor settings which takes care of these transitional period of missing report here or can be handled by introducing gracePeriod global setting. I can see what you are talking about but not what you are saying here. Do you mean that we need to keep track of ping interval and grace period in the statemachine for a particular VM? [Anshul] Here I am just talking about changing global setting “ping.interval” value or adding one more global setting for grace period to get more finer control for these kind of scenarios. Regards, Anshul On 16-Sep-2015, at 1:11 PM, Rohit Yadav <rohit.ya...@shapeblue.com<mailto:rohit.ya...@shapeblue.com><mailto: rohit.ya...@shapeblue.com<mailto:rohit.ya...@shapeblue.com>>> wrote: On 16-Sep-2015, at 1:06 pm, Daan Hoogland <daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com><mailto: daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com>>> wrote: so two questions: - is this a blocker? A missing state handler is definitely a corner case, and IMO a blocker (so, for both 4.6.0 and future 4.5.3). - is the ignoring after logging the appropriate way to handle this? It may be undesirable for all cases; so either introducing another global setting to control logic (just log, vs update state in the db vs do any operation?); or simply find out if the VM is actually running (or any other state) just mark it as running in the DB. Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com<mailto:rohit.ya...@shapeblue.com><mailto: rohit.ya...@shapeblue.com<mailto:rohit.ya...@shapeblue.com>> Blog: bhaisaab.org<http://bhaisaab.org><http://bhaisaab.org/> | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build< http://shapeblue.com/iaas-cloud-design-and-build//> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> CloudStack Software Engineering< http://shapeblue.com/cloudstack-software-engineering/> CloudStack Infrastructure Support< http://shapeblue.com/cloudstack-infrastructure-support/> CloudStack Bootcamp Training Courses< http://shapeblue.com/cloudstack-training/> This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark. -- Daan