GitHub user iishitahere added a comment to the discussion: Wrong Traffic Shaping in Secondary NIC over L2 networks
> Hello, @luganofer and @iishitahere > > From what I remember of the code, the throttling is applied differently if > the NIC of the VM is the default one or not. > > https://github.com/apache/cloudstack/blob/db2e89a3a2c9e8df2d24ed3e6aeae280bf22f0ba/server/src/main/java/com/cloud/network/NetworkModelImpl.java#L1037 > > For the default NIC, the network throttling is applied based on the compute > offering network bandwidth of the VM. If there is no limit set in the compute > offering, the value of the configuration `vm.network.throttling.rate` will be > used. > > For additional NICs, the network throttling is applied based on the network > offering bandwidth. If there is no limit set in the network offering, then > the value of the configuration `network.throttling.rate` will be used. > > To be fair, this behavior is kind of confusing, and maybe a discussion should > be done before any actual implementation. > > What do you guys think? cc @DaanHoogland @JoaoJandre @GutoVeronezi > @weizhouapache Hello @BryanMLima , @luganofer Thank you for pointing out the behavior of network throttling for default and additional NICs. I agree that the current approach can be somewhat confusing. I’d like to explore this issue further to clarify and potentially improve the implementation. Here’s how I plan to proceed: Analyze the existing logic in NetworkModelImpl.java to ensure a comprehensive understanding of the throttling rules for both NIC types. Propose a consistent or more intuitive mechanism for throttling, balancing functionality and ease of configuration. Incorporate input from the team to ensure alignment with the broader system design. Could you assign this issue to me so I can take the lead on the discussion and possible implementation? I’m excited to contribute! Looking forward to your thoughts. Best regards, Ishita GitHub link: https://github.com/apache/cloudstack/discussions/12378#discussioncomment-15423402 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
