Hi!
Reading the corosync.conf manual page of corosync 2.3.6 (SLES12 SP4), I have
some random comments:
The tag indent for "clear_node_high_bit" seems broken.
Ack, should be fixed
Shouldn't "hold" be "token_hold"? Why is "token_retransmits_before_loss_const" so long
(why the "_const")?
Why do you think "hold" should be "token_hold"?
"token_retransmits_before_loss_const" - yes, it is long. Why do you see
it as a problem?
The description states "...retransmit and hold will be automatically calculated...". Shouldn't
that be "token_retransmit" (also see my earlier remark on "hold")?
Yeps
For "token" the page says "Reforming a new configuration takes about 50 milliseconds..." shouldn't
"50 ms" be "join timeout"?
Nope, but I can agree comment should be reformulated.
"consensus should be larger then token" : ".. larger than .."?
Ack
"... which stil guarantee...": "still guarantee"? Maybe try a spell-checker ;-)
Ack first part
In general the manual page would benefit if all parameter names were set in bold face, as
in "as node count grows if consensus is less than token".
Terrible sentences: "This constant specifies how many rotations of the token
without receiving any of the messages when messages should be received may occur before
a new configuration is formed."
This seems to be just fine
"This specifies the number of times a problem is detected ...": "...a problem has to
be detected..."?
RRP so almost ENOTCARE, but I will happily accept patch.
"If this value is set, retransmit and hold will be automatically calculated from
retransmits_before_loss and token.": the parameter "retransmits_before_loss" is not
documented!
Ack
Regards,
Honza
Regards,
Ulrich
_______________________________________________
Manage your subscription:
https://lists.clusterlabs.org/mailman/listinfo/users
ClusterLabs home: https://www.clusterlabs.org/
_______________________________________________
Manage your subscription:
https://lists.clusterlabs.org/mailman/listinfo/users
ClusterLabs home: https://www.clusterlabs.org/
