I found a bug in the 2.7.2 code and would like to know how to submit it. The
bug is so obvious you don't even need code to reproduce it to realize it is
a bug. Observe the following code from JettHTTPServerEngine.java especially
line 3:
protected void retrieveListenerFactory() {
if (tlsServerParameters != null) {
if (null != connector && !(connector instanceof
SslSocketConnector)) {
LOG.warning("Connector " + connector + " for
JettyServerEngine Port "
+ port + " does not support SSL connections.");
return;
}
connectorFactory =
getHTTPSConnectorFactory(tlsServerParameters);
protocol = "https";
} else {
if (connector instanceof SslSocketConnector) {
throw new RuntimeException("Connector " + connector + " for
JettyServerEngine Port "
+ port + " does not support non-SSL connections.");
}
connectorFactory = getHTTPConnectorFactory();
protocol = "http";
}
LOG.fine("Configured port " + port + " for \"" + protocol + "\".");
}
Now ask yourself: what were to happen if I were using
SslSelectChannelConnector instead of SslSocketConnector? I can work around
this problem if I use code to create my engine and was thus able to verify
that SslSelectChannelConnector works fine. However, if I use Spring to
create my engine I'm out of luck... I have to use SslSocketConnector or it
fails. Another way I verified that SslSelectChannel connector works fine is
by breaking in the code during instantiation by Spring and forcing the
protocol to "https" which results in a perfectly responsive HTTPS port even
though the code logic does not allow it.
I'm perfectly happy to create an but item for this if someone gives me
access to do so (or at least explains what to do). I'm even happy to make
the change myself is someone also spends just a little bit of time giving me
some guidance on how to do so.
Thanks,
D
--
View this message in context:
http://cxf.547215.n5.nabble.com/Bug-in-2-7-2-tp5722635.html
Sent from the cxf-user mailing list archive at Nabble.com.
