Re: Swagger2feature / 3.1.12 (DOSGI)

Sergey Beryozkin Tue, 31 Oct 2017 06:17:45 -0700

Hi

Thanks for the confirmation, 3.2.1 will probably be available in centralnext week


Sergey
On 27/10/17 06:01, nino martinez wael wrote:

I think my IDE cached exactly that dependency.. I can confirm that youguard/fix are working :) Do you know when 3.2.1 will be released?



regards Nino

On Thu, Oct 26, 2017 at 4:20 PM, Sergey Beryozkin <sberyoz...@gmail.com<mailto:sberyoz...@gmail.com>> wrote:


    As I said, I've added a check there, try 3.1.14-SNAPSHOT

    Sergey
    On 26/10/17 13:09, nino martinez wael wrote:

        okay, I have what are happening.. First call are spring that
        sets the host property.. Immediately after this, the following
        happens:

        AbstractSwaggerFeature.initialize:67 are being called. which hits


        Swagger2Feature.setBasePathByAddress:423 with the
        valuehttp://0.0.0.0:9000/swaggerSample
        <http://0.0.0.0:9000/swaggerSample>  which causes it to reset
        the host to http://0.0.0.0:9000...


        SO


        protected void setBasePathByAddress(String address) {
              if (!address.startsWith("/")) {
                  URI u = URI.create(address);
                  this.setBasePath(u.getPath());
                  this.setHost(u.getPort() <0 ? u.getHost() :
        u.getHost() +":" + u.getPort());
              }else {
                  this.setBasePath(address);
              }

        }

        should be


        protected void setBasePathByAddress(String address) {
              if (!address.startsWith("/") && host == null) {
                  URI u = URI.create(address);
                  this.setBasePath(u.getPath());
                  this.setHost(u.getPort() <0 ? u.getHost() :
        u.getHost() +":" + u.getPort());
              }else {
                  this.setBasePath(address);
              }

        }


        If somebody already set the host it should probably not be
        overwritten? OR remove the setHost statement altogether?






        On Thu, Oct 26, 2017 at 1:59 PM, nino martinez wael
        <nino.martinez.w...@gmail.com
        <mailto:nino.martinez.w...@gmail.com>
        <mailto:nino.martinez.w...@gmail.com
        <mailto:nino.martinez.w...@gmail.com>>> wrote:

             Hi again

             I've been stepping through the code, and something are
        definitely
             wrong. All other properties set in the app context xml have
        been
             processed and set in the swagger 2 feature and are acting
        logical..
             BUT the HOST property are 0.0.0.0:9000
        <http://0.0.0.0:9000> <http://0.0.0.0:9000> on
             initialization.. Which seems strange, I'll debug some more
        and see
             what are modifying the property..

             On Mon, Oct 23, 2017 at 11:56 AM, Sergey Beryozkin
             <sberyoz...@gmail.com <mailto:sberyoz...@gmail.com>
        <mailto:sberyoz...@gmail.com <mailto:sberyoz...@gmail.com>>> wrote:

                 Thanks, sure, I've added a guard there to avoid
        auto-setting the
                 host value if it's not null, you can try 3.1.14-SNAPSHOT or
                 3.2.1-SNAPSHOT now.
                 However, the question remains where '0.0.0.0' comes
        from in your
                 case, when no host is set, which is a typical scenario,
        and I
                 can see it is reported from URI.getHost().

                 What address value do you see in
                 Swagger2Feature.setBasePathByAddress, before it tries to
                 auto-set the host ?

                 Sergey

                 On 23/10/17 05:47, nino martinez wael wrote:

                     It enters the conditional statement (sethost have been
                     called). And address becomes
                     "http://0.0.0.0:9090/tdc/dialer/webservices/v1
        <http://0.0.0.0:9090/tdc/dialer/webservices/v1>
                     <http://0.0.0.0:9090/tdc/dialer/webservices/v1
        <http://0.0.0.0:9090/tdc/dialer/webservices/v1>>"




                     On Thu, Oct 12, 2017 at 3:51 PM, Sergey Beryozkin
                     <sberyoz...@gmail.com <mailto:sberyoz...@gmail.com>
        <mailto:sberyoz...@gmail.com <mailto:sberyoz...@gmail.com>>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>>
                     wrote:

                          Hmm... I may've been wrong with some of the
        assumptions
                     about what
                          Swagger2Feature does.

                          Can you please do a breakpoint at

        
https://github.com/apache/cxf/blob/cxf-3.1.12/rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/AbstractSwaggerFeature.java#L103
        
<https://github.com/apache/cxf/blob/cxf-3.1.12/rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/AbstractSwaggerFeature.java#L103>

<https://github.com/apache/cxf/blob/cxf-3.1.12/rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/AbstractSwaggerFeature.java#L103

        
<https://github.com/apache/cxf/blob/cxf-3.1.12/rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/AbstractSwaggerFeature.java#L103>>

<https://github.com/apache/cxf/blob/cxf-3.1.12/rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/AbstractSwaggerFeature.java#L103

        
<https://github.com/apache/cxf/blob/cxf-3.1.12/rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/AbstractSwaggerFeature.java#L103>

<https://github.com/apache/cxf/blob/cxf-3.1.12/rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/AbstractSwaggerFeature.java#L103

        
<https://github.com/apache/cxf/blob/cxf-3.1.12/rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/AbstractSwaggerFeature.java#L103>>>

                          and see what happens, without even doing
        setHost().

                          I won't have time for a while to investigate
        it. But
                     I'll take care
                          of adding a test for checking that setHost()
        works later on

                          Cheers, Sergey

                          On 12/10/17 13:42, nino martinez wael wrote:

                              Sure, I've made the changes to the cxf
        spring boot
                     sample:

        
https://github.com/nmwael/cxf/commit/86630259982786f013faad658e84bd27bca368b7
        
<https://github.com/nmwael/cxf/commit/86630259982786f013faad658e84bd27bca368b7>

<https://github.com/nmwael/cxf/commit/86630259982786f013faad658e84bd27bca368b7

        
<https://github.com/nmwael/cxf/commit/86630259982786f013faad658e84bd27bca368b7>>

<https://github.com/nmwael/cxf/commit/86630259982786f013faad658e84bd27bca368b7

        
<https://github.com/nmwael/cxf/commit/86630259982786f013faad658e84bd27bca368b7>

<https://github.com/nmwael/cxf/commit/86630259982786f013faad658e84bd27bca368b7

        
<https://github.com/nmwael/cxf/commit/86630259982786f013faad658e84bd27bca368b7>>>


                              The resulting swagger.json does not honor
        the host
                     property,
                              host remains the same no matter what:

                              "host":"0.0.0.0:9000 <http://0.0.0.0:9000>
        <http://0.0.0.0:9000>
                     <http://0.0.0.0:9000> <http://0.0.0.0:9000>"







                              On Thu, Oct 12, 2017 at 1:32 PM, Sergey
        Beryozkin
                              <sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>>> wrote:

                                   Hi

                                   CXF does not contribute itself to the
                     generation of 'host'
                              within
                                   the Swagger JSON. For example, try a
                     jaxrs/spring-boot
                              demo, or some
                                   of other swagger2 demos...

                                   If you'd like you can get the CXF
        source, and
                     step through
                              the CXF
                                   Swagger2Feature

                                   Sergey

                                   On 12/10/17 11:06, nino martinez wael
        wrote:

                                       Hi Sergey,

                                       I've tried this:

                                       Swagger2Feature swagger =new
                     Swagger2Feature();

                                       swagger.setHost("127.0.0.1:9090
        <http://127.0.0.1:9090>
                     <http://127.0.0.1:9090> <http://127.0.0.1:9090>
                              <http://127.0.0.1:9090>
                                       <http://127.0.0.1:9090>");

                                       swagger.setUsePathBasedConfig(true);


                                       BUT the swagger json still states:


        0.0.0.0:9090 <http://0.0.0.0:9090> <http://0.0.0.0:9090>
        <http://0.0.0.0:9090>
                     <http://0.0.0.0:9090>
                              <http://0.0.0.0:9090>


                                       As far as I can see it is
        something CXF
                     generates.. I cant
                                       really pinpoint where CXF grabs the
                     configuration from,
                              but if I
                                       change

                                       swagger.setLicense("Commercial
        DOES THIS
                     APPLY?");


                                       It does apply in the swagger json
        and I am
                     able to
                              change that
                                       part, it is as CXF ignores the
                     swagger.getHOST method...



                                       On Thu, Oct 12, 2017 at 11:25 AM,
        Sergey
                     Beryozkin
                                       <sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>>
                                       <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>>>> wrote:

                                            In this case it is really
        somewhere
                     in the Swagger
                              code

                                            Sergey
                                            On 11/10/17 18:29, nino
        martinez wael
                     wrote:

                                                No problem, I tried both
                     configurations but no
                              matter
                                       what I do,
                                                the host remains the same
        0.0.0.0:9090 <http://0.0.0.0:9090> <http://0.0.0.0:9090>
                              <http://0.0.0.0:9090>
                                       <http://0.0.0.0:9090>
        <http://0.0.0.0:9090>
                                                <http://0.0.0.0:9090>

                                                On 11 Oct 2017 15:51,
        "Sergey
                     Beryozkin"
                                       <sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>>

<mailto:sberyoz...@gmail.com <mailto:sberyoz...@gmail.com>

                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>
                                       <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>>>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>
                                       <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>> <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>>

<mailto:sberyoz...@gmail.com <mailto:sberyoz...@gmail.com>

                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>
                                       <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>
                              <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>
                     <mailto:sberyoz...@gmail.com
        <mailto:sberyoz...@gmail.com>>>>>>> wrote:

                                                     Sorry, I
        accidentally moved
                     it from the
                              users list,


                                                     On 11/10/17 14:42, nino
                     martinez wael wrote:

                                                         Sure, in my
        example you
                     can see that host
        0.0.0.0:9090 <http://0.0.0.0:9090> <http://0.0.0.0:9090>
        <http://0.0.0.0:9090>
                     <http://0.0.0.0:9090>
                                                <http://0.0.0.0:9090>

<http://0.0.0.0:9090>

                              <http://0.0.0.0:9090>
                                       have been
                                                         generated..
        However calling

        http://0.0.0.0:9090/tdc/dialer/webservices/v1/fullcampaigns
        <http://0.0.0.0:9090/tdc/dialer/webservices/v1/fullcampaigns>