On 6 Nov 2017, at 17:06, Roland Haas <rh...@illinois.edu> wrote: > * 6 failing tests > ** prolongation one is new, need input from Erik, want trac ticket
It turns out that this was already discussed in the original ticket for the feature, https://trac.einsteintoolkit.org/ticket/2068, and was fixed in a pull request https://bitbucket.org/eschnett/carpet/pull-requests/19/correct-error-in-vertex-centred/diff, which was reviewed as OK by Roland in https://trac.einsteintoolkit.org/ticket/2074, but never applied. I just applied it. Hopefully it will fix the problems. > ** SphericalHarmonicReconGen: could be bug in the reader or in PITTNull > code. PITTNull is sensitive to optimization since it includes the full > Einstein field equations. Check if using -O3 instead of -Ofast would > help. > ** have generic.cfg and generic-opt.cfg, get rid of debian.cfg, > ubuntu.cfg etc. I would suggest that generic.cfg should be more conservative, since it is the default probably used by new users, and we don't want them running into edge cases caused by aggressive optimisations. Can we reduce the optimisation level in generic.cfg to -O2? Then we could have a generic-no-opt or something, which really had no optimisations at all. -- Ian Hinder http://members.aei.mpg.de/ianhin
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ Users mailing list Users@einsteintoolkit.org http://lists.einsteintoolkit.org/mailman/listinfo/users
