I'm assuming that compiler optimizations would make both patches "six to
one, half dozen to the other" as far as code path followed during the
request cycle... but I agree.

Fixed in trunk in r1737114 and proposed for backport in 2.4 in STATUS.

-- 
Daniel Ruggeri

On 3/30/2016 8:02 AM, Plüm, Rüdiger, Vodafone Group wrote:
>
> But the attached patch is not correct. IMHO it needs to be
>
>  
>
> Index: request.c
>
> ===================================================================
>
> --- request.c   (revision 1735931)
>
> +++ request.c   (working copy)
>
> @@ -1009,7 +1009,9 @@
>
>                  /* No htaccess in an incomplete root path,
>
>                   * nor if it's disabled
>
>                   */
>
> -                if (seg < startseg || (!opts.override &&
> opts.override_list == NULL)) {
>
> +                if (seg < startseg || (!opts.override
>
> +                                       &&
> apr_is_empty_table(opts.override_list)
>
> +                                       )) {
>
>                      break;
>
>                  }
>
>  
>
>  
>
> Regards
>
>  
>
> Rüdiger
>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@httpd.apache.org
For additional commands, e-mail: users-h...@httpd.apache.org

Reply via email to