Hi Christian, On 18 January 2013 22:21, Christian Steinebach < [email protected]> wrote:
> But I had to change the file isis/example/misc/metamodel/namefile/pom.xml > I included > <build> > <pluginManagement> > <plugins> > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-compiler-plugin</artifactId> > <version>2.3.1</version> > <configuration> > <source>1.6</source> > <target>1.6</target> > </configuration> > </plugin> > </plugins> > </pluginManagement> > </build> > > otherwise maven tried to compile for java 1.3 and crashed > Not sure why that should be needed for you but not for me; but does no harm and so have added. Thanks. > > When running the wicket_restful application, a [completed] button appears > for both tables, 'Complete' and 'Not Yet Completed' > When checking some of the ToDoItems in the list of all NotYetComplete > items, clicking the button 'completes' the items. > When checking some of the ToDoItems in the list of 'Completed' items, > clicking the button reloads the page and does nothing. > Yup, that sounds correct. I suppose it's a bit odd that the ToDoItem#completed() bulk action renders on the list of ToDoItems returne from the "ToDoItems#completed()", when - obviously - it's always going to be a no-op for that collection of items. But there's no way to suppress it. We could I suppose morph this thread into a discussion about how one might suppress it. One idea I have would be to allow the developer to introduce domain types such as CompletedItemsList extends ArrayList and having the action return instances of this type (rather than a simple List), and add in some metadata somewhere to determine whether the bulk action appears with respect to the CompletedItemsList. As you can see, though, such a design would be rather complicated and require a lot of new infrastructure to support. I'm not that keen to go there right now... Cheers Dan > > Thanks again. I'll try it out with my own simple model. > > Christian > > > > > ________________________________________ > From: Dan Haywood [[email protected]] > Sent: Friday, January 18, 2013 10:23 PM > To: users > Subject: RE: multiple selection lists? > > Do another fetch of latest.. those failing tests were my mistake, should > now be fixed I hope. > > Dan > > Sorry to be brief, sent from my phone > On Jan 18, 2013 8:48 PM, "Christian Steinebach" < > [email protected]> wrote: > > > Hi Dan! > > > > Thanks you very much for taking the time!! :-) > > I'm still struggeling, though, with the building of isis from source. > > I pulled the latest version from github. The compilation still stopped in > > the metamodel module. > > I'm running Ubuntu, which by default uses the openjdk java toolkit. > > I therefore installed oracle's jdk. That made a difference. :-) The > > metamodel module compiles. > > > > But now some of the tests in core runtime fail, see the log below. > > > > ..... > > [INFO] Building Isis Core Runtime 1.0.1-SNAPSHOT > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] > > [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ > > isis-core-runtime --- > > [INFO] > > [INFO] --- maven-remote-resources-plugin:1.4:process (default) @ > > isis-core-runtime --- > > [INFO] > > [INFO] --- maven-remote-resources-plugin:1.4:process > > (process-remote-resources) @ isis-core-runtime --- > > [INFO] Skipping remote-resource generation in this project because it's > > not the Execution Root > > [INFO] > > [INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ > > isis-core-runtime --- > > [INFO] Using 'UTF-8' encoding to copy filtered resources. > > [INFO] Copying 1 resource > > [INFO] Copying 9 resources > > [INFO] Copying 3 resources > > [INFO] > > [INFO] --- maven-compiler-plugin:2.3.1:compile (default-compile) @ > > isis-core-runtime --- > > [INFO] Compiling 221 source files to > > /home/chris/NetBeansProjects/isis/core/runtime/target/classes > > [INFO] > > [INFO] --- maven-resources-plugin:2.4.3:testResources > > (default-testResources) @ isis-core-runtime --- > > [INFO] Using 'UTF-8' encoding to copy filtered resources. > > [INFO] skip non existing resourceDirectory > > /home/chris/NetBeansProjects/isis/core/runtime/src/test/resources > > [INFO] Copying 3 resources > > [INFO] > > [INFO] --- maven-compiler-plugin:2.3.1:testCompile (default-testCompile) > @ > > isis-core-runtime --- > > [INFO] Compiling 47 source files to > > /home/chris/NetBeansProjects/isis/core/runtime/target/test-classes > > [INFO] > > [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ > > isis-core-runtime --- > > [INFO] Surefire report directory: > > /home/chris/NetBeansProjects/isis/core/runtime/target/surefire-reports > > > > ------------------------------------------------------- > > T E S T S > > ------------------------------------------------------- > > > > Results : > > > > Tests in error: > > > > > destroyObjectThenAbort(org.apache.isis.core.runtime.persistence.objectstore.PersistenceSessionObjectStoreTest) > > > > > destroyObject_thenCommit(org.apache.isis.core.runtime.persistence.objectstore.PersistenceSessionObjectStoreTest) > > > > > makePersistent_happyCase(org.apache.isis.core.runtime.persistence.objectstore.PersistenceSessionObjectStoreTest) > > > > Tests run: 142, Failures: 0, Errors: 3, Skipped: 13 > > > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Reactor Summary: > > [INFO] > > [INFO] Apache Isis Core .................................. SUCCESS > [3.425s] > > [INFO] Isis Core AppLib .................................. SUCCESS > [7.249s] > > [INFO] Isis Core Unit Test Support ....................... SUCCESS > [2.068s] > > [INFO] Isis Core MetaModel ............................... SUCCESS > > [20.666s] > > [INFO] Isis Core Runtime ................................. FAILURE > [7.236s] > > [INFO] Isis Core WebServer ............................... SKIPPED > > ..... > > > > > > Christian > > > > > > > > > > > > > > > > > > > > > > ________________________________________ > > From: Dan Haywood [[email protected]] > > Sent: Friday, January 18, 2013 5:14 PM > > To: [email protected] > > Cc: dev > > Subject: Re: multiple selection lists? > > > > Hi Christian, > > OK, I've been doing some work on this issue, and it is now fixed, I > think, > > in master. > > > > It's required changes to both core and the wicket viewer, so it'll get > > released in isis-1.1.0 and isis-wicket-viewer-1.1.0 (probably a Feb > > timeframe). > > > > It works through a new annotation, @Bulk. If added to an action (either > an > > entity action or a service action to be contributed), then the action is > > rendered in the table view. It is called for each of the checked > entities > > in the table. > > > > @Bulk actions are slightly different from regular actions (hence the > > explicit annotation) in that any business rules (hidden, disabled or > > validation) are NOT called. Therefore it is the responsibility of the > > programmer to guard for this; the method should just do nothing if its > > preconditions are not met. > > > > Also, at this point in time, @Bulk actions cannot take arguments. That > is, > > an entity action must be a no-arg, while a contributed service action > > should take precisely 1 argument. > > > > To try this out, you'll need to build Isis from source, of course. > > > > Rob/Kevin/other devs: > > I think this design should degrade gracefully for other viewers such as > > Scimpi and HTML that don't yet understand this new annotation; they will > > simply continue to render in the same way. > > > > Let me know how you get on. > > Dan > > > > > > On 17 January 2013 18:35, Jeroen van der Wal <[email protected]> > wrote: > > > > > Hi Christian, > > > > > > The intention is that methods on the the repository are picked up as a > > > "contributed action" when their return type is void and have a single > > > parameter. We've checked but apparently It doesn't work. A ticket has > > been > > > raised [1] > > > > > > I don't know if this mechanism could also be applied to collections, > will > > > have to find out. > > > > > > Cheers, > > > > > > Jeroen > > > > > > [1] https://issues.apache.org/jira/browse/ISIS-304 > > > > > > > > > > > > On Wed, Jan 16, 2013 at 10:43 PM, Christian Steinebach < > > > [email protected]> wrote: > > > > > > > Hi! > > > > > > > > In the ToDo application, when listing AllToDos there are check boxes > > > > available for each row of the table. > > > > How can the selections be processed? > > > > > > > > Is it possible to add check boxes to the table view of collections, > > such > > > > as 'Dependencies' (in the ToDo application) and process > > > > them, i.e. mark some dependencies for removal? > > > > I could not find any hint in the documentation. > > > > > > > > Thanks in advance > > > > Christian > > > > > >
