Hi Erik, I've raised and fixed ISIS-1446 [1] for this; will be in 1.13.0. If you get the chance to test it out, that would be good. Note that the ComponentType enum value is now ENTITY_COLLECTION (it was ENTITY_COLLECTIONS in v1.11.x).
Thanks Dan [1] https://issues.apache.org/jira/browse/ISIS-1448 On 9 May 2016 at 09:33, Erik de Hair <[email protected]> wrote: > Hi Dan, > > On 05/05/2016 09:19 AM, Dan Haywood wrote: > >> Hi Erik, >> >> I think that's an oversight... I can't thing of any particularly good >> reason for this class not to use ComponentFactory. >> > Could you take a look at [1]? I expected some component factory method > there. If it should be using a component factory there I will try to fix > that. Otherwise, could you tell me why it is the way it is now? > >> >> There is actually a new SPI you could use to patch this... provide a new >> implementation of GridSystemService (subclassing the default BS3 impl and >> using @DomainService (menuOrder="1") to ensure your patched version is >> found before the default impl). >> > That sounds good. I'll take a look at that. > > Thanks, > Erik > > [1] > https://github.com/apache/isis/blob/master/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/layout/bs3/col/Col.java#L277 >
