Yeah, that works perfectly! ;-) Thanks a lot for fixing that immediately, Christophe...
Regards Hendrik > -----Original Message----- > From: Christophe Lombart [mailto:[EMAIL PROTECTED] > Sent: Thursday, September 13, 2007 4:48 AM > To: [email protected] > Subject: Re: [OCM] Binary values from byte[] field > > I just commit a patch. Can you check if it is ok for you ? > > Thanks, > Christophe > > > On 9/12/07, Christophe Lombart <[EMAIL PROTECTED]> wrote: > > > > huuuhh yes :-) we can modify the code like this. Probably a big mistake > > when I write the code. > > > > On 9/12/07, Carsten Ziegeler < [EMAIL PROTECTED]> wrote: > > > > > > Christophe Lombart wrote: > > > > Hi Hendrik, > > > > > > > > I'm not 100 % sure that is related to a charset mismatch. This is > not > > > easy > > > > to find the solution right now. > > > > It seems that happens when you try open it after a second save right > ? > > > When > > > > you open it after the first save, is it working ? > > > > What do you mean by can't open it' ? Did you get an exception ? > > > > > > > > > > > > Anyway, we should give the possibility to use this constructor : > > > public > > > > String(byte[] bytes, String charsetName) > > > > But I'm just wondering how is possible to get the charset from this > > > code > > > > location (ByteArrayTypeConverterImpl). > > > > > > > I might be out of context, but wouldn't it be better to treat a binary > > > values as a binary and not convert it into a String? Any conversion of > > > arbitrary data to a String can lead to problems no matter what > encoding > > > you're using. So perhaps just using a byte array input stream would be > > > better? > > > > > > Carsten > > > -- > > > Carsten Ziegeler > > > [EMAIL PROTECTED] > > > > > > >
