And how do you test the resulting code?

Gary

On Thu, Jan 12, 2023, 02:57 Maxim Solodovnik <solomax...@gmail.com> wrote:

> Hello Julian,
>
> I've just modified jackrabbit-webdav/pom.xml as follows:
>
> diff --git a/jackrabbit-webdav/pom.xml b/jackrabbit-webdav/pom.xml
> index b7941a4ee..795858aaf 100644
> --- a/jackrabbit-webdav/pom.xml
> +++ b/jackrabbit-webdav/pom.xml
> @@ -51,6 +51,37 @@
>            <argLine>${test.opts}</argLine>
>          </configuration>
>        </plugin>
> +      <plugin>
> +        <groupId>org.apache.maven.plugins</groupId>
> +        <artifactId>maven-shade-plugin</artifactId>
> +        <version>3.4.1</version>
> +        <executions>
> +          <execution>
> +            <id>shade-jakarta</id>
> +            <phase>package</phase>
> +            <goals>
> +              <goal>shade</goal>
> +            </goals>
> +            <configuration>
> +              <shadedArtifactAttached>true</shadedArtifactAttached>
> +              <shadedClassifierName>jakarta</shadedClassifierName>
> +
> <createDependencyReducedPom>false</createDependencyReducedPom>
> +              <createSourcesJar>true</createSourcesJar>
> +              <artifactSet>
> +                <includes>
> +                  <include>org.apache.jackrabbit.webdav</include>
> +                </includes>
> +              </artifactSet>
> +              <relocations>
> +                <relocation>
> +                  <pattern>javax.servlet</pattern>
> +                  <shadedPattern>jakarta.servlet</shadedPattern>
> +                </relocation>
> +              </relocations>
> +            </configuration>
> +          </execution>
> +        </executions>
> +      </plugin>
>      </plugins>
>    </build>
>
> As a result I got valid jackrabbit-webdav-2.21.15-SNAPSHOT-jakarta.jar
> and was able to use it as follows:
>
> <dependency>
>     <groupId>org.apache.jackrabbit</groupId>
>     <artifactId>jackrabbit-webdav</artifactId>
>     <version>2.21.15-SNAPSHOT</version>
>     <classifier>jakarta</classifier>
> </dependency>
>
> at least compilation was successful :)))
>
> Shall I create a PR?
>
> On Thu, 12 Jan 2023 at 00:24, Julian Reschke <julian.resc...@gmx.de>
> wrote:
> >
> > On 11.01.2023 18:18, Julian Reschke wrote:
> > > On 11.01.2023 17:54, KÖLL Claus wrote:
> > >> That's really funny ...
> > >>
> > >> I have today created the jakarta version for jackrabbit-jcr-server and
> > >> jackrabbit-webdav
> > >> for our internal projects because we have started migrating to
> > >> jakartae EE 9 now.
> > >>
> > >> It's really easy with the transformer-maven-plugin. We used it for
> > >> many other projects the same way.
> > >> So if i should bring sone help in here let me know.
> > >>
> > >> greets
> > >> claus
> > >
> > > Absolutely. Will it just produce additional artefacts?
> > >
> > > Best regards, Julian
> >
> > FWIW; I'm also looking for help to get the standalone project upgraded
> > to a newer Jetty version (see
> > https://issues.apache.org/jira/browse/JCR-4308).
> >
> > Best regards, Julian
>
>
>
> --
> Best regards,
> Maxim
>

Reply via email to