Hey Bill, Thanks for reading the KIP, much appreciated.
The reason we want it to be a separate Partitioner is because: a) We don’t want to specify partition anywhere. b) we want to be able to reuse what’s been done for NULL key in DefaultPartitioner. Using the constructor means we need to assign partition manually in the code. I’m not sure if it I managed to clarify our need. Also, this means no change in any existing code. It’s a new class in Kafka trunk which doesn’t disrupt any exising operation. Thanks, On Thu, 30 Aug 2018 at 18:12, Bill Bejeck <b...@confluent.io> wrote: > Hi, > > NOTE: I sent this earlier, but that message just went to the dev list. I'm > including both users and dev now. > > Thanks for the KIP. > > Have you considered using the overloaded ProducerRecord constructor where > you can specify the partition? I mention this as an option as I > encountered the same issue on a previous project and that is how we handled > round-robin distribution with non-null keys. > > Would that suit your needs? > > Thanks, > Bill > > On Thu, Aug 30, 2018 at 11:58 AM Harsha <ka...@harsha.io> wrote: > > > Hi, > > Thanks for the KIP. I am trying to understand the intent of the > > KIP. Is the use case you specified can't be achieved by implementing the > > Partitioner interface here? > > > https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java#L28 > > . > > Use your custom partitioner to be configured in your producer clients. > > > > Thanks, > > Harsha > > > > On Thu, Aug 30, 2018, at 1:45 AM, M. Manna wrote: > > > Hello, > > > > > > I opened a very simple KIP and there exists a JIRA for it. > > > > > > I would be grateful if any comments are available for action. > > > > > > Regards, > > >
