Thanks. Can you open a Jira for this issue? -Matthias
On 2/25/19 7:04 AM, Patrik Kleindl wrote:
> Hi Matthias
> Minor issue, if locale is not english (german in my case) then
> org.apache.kafka.common.utils.UtilsTest > testFormatBytes FAILED
> org.junit.ComparisonFailure: expected:<1[.]1 MB> but was:<1[,]1 MB>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.kafka.common.utils.UtilsTest.testFormatBytes(UtilsTest.java:106)
> fails.
> Possible fix clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
>
> DecimalFormat TWO_DIGIT_FORMAT = ((DecimalFormat)
> NumberFormat.getInstance(Locale.ENGLISH));
> TWO_DIGIT_FORMAT.applyPattern("0.##");
>
> or fix the expectation of the test based on the locale.
> If english locale is expected to build I might have missed it.
>
> br, Patrik
>
> On Sun, 24 Feb 2019 at 00:57, Matthias J. Sax <[email protected]> wrote:
>
>> Hello Kafka users, developers and client-developers,
>>
>> This is the first candidate for the release of Apache Kafka 2.2.0.
>>
>> This is a minor release with the follow highlight:
>>
>> - Added SSL support for custom principle name
>> - Allow SASL connections to periodically re-authenticate
>> - Improved consumer group management
>> - default group.id is `null` instead of empty string
>> - Add --under-min-isr option to describe topics command
>> - Allow clients to suppress auto-topic-creation
>> - API improvement
>> - Producer: introduce close(Duration)
>> - AdminClient: introduce close(Duration)
>> - Kafka Streams: new flatTransform() operator in Streams DSL
>> - KafkaStreams (and other classed) now implement AutoClosable to
>> support try-with-resource
>> - New Serdes and default method implementations
>> - Kafka Streams exposed internal client.id via ThreadMetadata
>> - Metric improvements: All `-min`, `-avg` and `-max` metrics will now
>> output `NaN` as default value
>>
>>
>> Release notes for the 2.2.0 release:
>> http://home.apache.org/~mjsax/kafka-2.2.0-rc0/RELEASE_NOTES.html
>>
>> *** Please download, test and vote by Friday, March 1, 9am PST.
>>
>> Kafka's KEYS file containing PGP keys we use to sign the release:
>> http://kafka.apache.org/KEYS
>>
>> * Release artifacts to be voted upon (source and binary):
>> http://home.apache.org/~mjsax/kafka-2.2.0-rc0/
>>
>> * Maven artifacts to be voted upon:
>> https://repository.apache.org/content/groups/staging/org/apache/kafka/
>>
>> * Javadoc:
>> http://home.apache.org/~mjsax/kafka-2.2.0-rc0/javadoc/
>>
>> * Tag to be voted upon (off 2.2 branch) is the 2.2.0 tag:
>> https://github.com/apache/kafka/releases/tag/2.2.0-rc0
>>
>> * Documentation:
>> https://kafka.apache.org/22/documentation.html
>>
>> * Protocol:
>> https://kafka.apache.org/22/protocol.html
>>
>> * Successful Jenkins builds for the 2.2 branch:
>> Unit/integration tests: https://builds.apache.org/job/kafka-2.2-jdk8/31/
>>
>> * System tests:
>> https://jenkins.confluent.io/job/system-test-kafka/job/2.2/
>>
>>
>>
>>
>> Thanks,
>>
>> -Matthias
>>
>>
>
signature.asc
Description: OpenPGP digital signature
