I think you're right about needing to throw here. I'll get that fixed for the next beta. AssemblyName's are an interesting idea, but I wonder if anyone will ever get an assembly name too.
I think it's probably best to stay away from that until we know of a scenario where this actually makes a difference. If someone really needs to interact that deeply w/ CLR loading they can always fall back to giving us the raw assembly object after doing an Assembly.Load(AssemblyName). But I'd rather add the feature later than have some useless dead code lingering around forever :). Do you want to help develop Dynamic languages on CLR? (http://members.microsoft.com/careers/search/details.aspx?JobID=6D4754DE-11F0-45DF-8B78-DC1B43134038) -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of J. Merrill Sent: Tuesday, February 21, 2006 12:50 PM To: Discussion of IronPython Subject: Re: [IronPython] IronPython 1.0 Beta 3 Released! Shouldn't the function below raise an exception if the object holds neither an assemnbly nor a string? Silence should not be a translation of "we ignored what you passed in because it was not an expected type" !! (Should there perhaps be another block supporting reference being an AssemblyName? I don't know where a Python programmer would get one, however.) At 12:36 PM 2/16/2006, Dino Viehland wrote (in part) >[snip] >Unfortunately then you'll start hitting the stack overflow bug that Jon >reported. His fix is close to being right, but really it should become: > > private void AddReference(object reference) { > Assembly asmRef = reference as Assembly; > if (asmRef != null) { > AddReference(asmRef); > return; > } > > string strRef = reference as string; > if (strRef != null) { > AddReference(strRef); > return; > } > } >[snip] J. Merrill / Analytical Software Corp _______________________________________________ users mailing list users@lists.ironpython.com http://lists.ironpython.com/listinfo.cgi/users-ironpython.com _______________________________________________ users mailing list users@lists.ironpython.com http://lists.ironpython.com/listinfo.cgi/users-ironpython.com
