Please fix the hcoll test (and code) to be correct.

Any configure test that adds /usr/lib and/or /usr/include to any compile flags is broken.

And if hcoll include files are under $HCOLL_HOME/include/hcoll (and hcoll/api) then the include directives in the source should be
#include <hcoll/xxx.h>
and
#include <hcoll/api/yy.h>
respectively.

I.e. one should never add -I$HCOLL_HOME/include/hcoll to CPPFLAGS, only -I$HCOLL_HOME/include.

Doing otherwise is bad design and a big cause for problems with include files from different packages having the same name...

My opinion at least...

On 08/11/2015 01:57 AM, Gilles Gouaillardet wrote:
David,

the configure help is misleading about hcoll ...

  --with-hcoll(=DIR)      Build hcoll (Mellanox Hierarchical Collectives)
                           support, searching for libraries in DIR

the =DIR is not really optional ...
configure will not complain if you configure with --with-hcoll or
--with-hcoll=yes
but hcoll will be disabled in this case

FWIW, here is a snippet of my config.status generate with
--with-hcoll=$HCOLL_HOME
/* i manually 'unexpaned' $HCOLL_HOME */
S["coll_hcoll_LIBS"]="-lhcoll "
S["coll_hcoll_LDFLAGS"]=" -L$HCOLL_HOME/lib"
S["coll_hcoll_CPPFLAGS"]=" -I$HCOLL_HOME/include"
S["coll_hcoll_CFLAGS"]=""
S["coll_hcoll_HOME"]="$HCOLL_HOME"
S["coll_hcoll_extra_CPPFLAGS"]="-I$HCOLL_HOME/include/hcoll
-I$HCOLL_HOME/include/hcoll/api"

bottom line, if you configure with --with-hcoll=/usr it will add some
useless flags such as -L/usr/lib (or -L/usr/lib64, i am not sure about
that) and -I/usr/include
but it will also add the required -I/usr/include/hcoll
-I/usr/include/hcoll/api flags

if you believe this is an issue, i can revamp the hcoll detection (e.g.
configure --with-hcoll) but you might
need to manually set CPPFLAGS='-I/usr/include/hcoll
-I/usr/include/hcoll/api'
if not, i guess i will simply update the configure help message ...

Cheers,

Gilles

On 8/11/2015 7:39 AM, David Shrader wrote:
Hello All,

I'm having some trouble getting Open MPI 1.8.8 to configure correctly
when hcoll is installed in system space. That is, hcoll is installed
to /usr/lib64 and /usr/include/hcoll. I get an error during configure:

$> Konsole output ./configure --with-hcoll
...output snipped...
Konsole output configure:219976: checking for MCA component coll:hcoll
compile mode
configure:219982: result: static
configure:220039: checking --with-hcoll value
configure:220042: result: simple ok (unspecified)
configure:220840: error: HCOLL support requested but not found. Aborting

I have also tried using "--with-hcoll=yes" and gotten the same
behavior. Has anyone else gotten the hcoll component to build when
hcoll itself is in system space? I am using hcoll-3.2.748.

I did take a look at configure, and it looks like there is a test on
"with_hcoll" to see if it is not empty and not yes on line 220072. In
my case, this test fails, so the else clause gets invoked. The else
clause is several hundred lines below on line 220822 and simply sets
Konsole output ompi_check_hcoll_happy="no". Configure doesn't try to
do anything to figure out if hcoll is usable, but it does quit soon
after with the above error because ompi_check_hcoll_happy isn't "yes."

In case it helps, here is the output from config.log for that area:

...output snipped...
configure:219976: checking for MCA component coll:hcoll compile mode
configure:219982: result: dso
configure:220039: checking --with-hcoll value
configure:220042: result: simple ok (unspecified)
configure:220840: error: HCOLL support requested but not found. Aborting

## ---------------- ##
## Cache variables. ##
## ---------------- ##
...output snipped...

Have I missed something in specifying --with-hcoll? I would prefer not
to use "--with-hcoll=/usr" as I am pretty sure that spurious linker
flags to that area will work their way in when they shouldn't.

Thanks,
David
--
David Shrader
HPC-3 High Performance Computer Systems
Los Alamos National Lab
Email: dshrader <at> lanl.gov


_______________________________________________
users mailing list
us...@open-mpi.org
Subscription:http://www.open-mpi.org/mailman/listinfo.cgi/users
Link to this 
post:http://www.open-mpi.org/community/lists/users/2015/08/27418.php



_______________________________________________
users mailing list
us...@open-mpi.org
Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
Link to this post: 
http://www.open-mpi.org/community/lists/users/2015/08/27419.php


--
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: a...@hpc2n.umu.se   Phone: +46 90 7866134 Fax: +46 90-580 14
Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se

Reply via email to