Ok Brian - everything is done, please update from SVN and give it a try. Regards, Bogdan
opensipsl...@encambio.com wrote: > Hi Bogdan, > > An lun., févr 01, 2010, Bogdan-Andrei Iancu schrieb: > >> opensipsl...@encambio.com wrote: >> >>> An mer., janv 27, 2010, Bogdan-Andrei Iancu schrieb: >>> >>>> opensipsl...@encambio.com wrote: >>>> >>>>> An sam., janv 23, 2010, opensipsl...@encambio.com schrieb: >>>>> >>>>>> I send a INVITE over TLS and it is routed properly (I can call >>>>>> normally.) The validate_dialog() is failing to match routesets. >>>>>> >>>>>> >>>>> By the way, I've tried all three possible dlg_match_mode modes, >>>>> and I've tried using create_dialog() instead of set_flag(dlg_flag). >>>>> Every time I see the error that the route check failed. >>>>> >>>>> >>>> Let me run some tests on this scenario (with proto changing). >>>> >>>> >>> I see from revision 6550 that you found some problem with dialog >>> matching and routeset comparisons. Do you recommend that we test >>> your changes, or is there some reason you've not written about it >>> on the mailing list? >>> >>> >> I'm still running some tests on it to be sure everything is ok. >> >> > Oh, that's why. I'll wait until you give the go ahead. > > >>> Also, the two comments of revision 6550 don't indicate if the >>> correction to routeset comparison is dependent on the new RR API >>> extension (reporting the number of lr removed routes.) >>> >>> >> both are related to the fix - dialog module needed some more info >> > >from RR in order to do a correct Route checking. > >>> Is it safe to build OpenSIPS with only the dialog routeset checking >>> correction and not the RR API extension? >>> >>> >> no - dialog will not compile anymore - update both. >> >> > Okay. > > >>> If these two comments describe independent changes, it might have >>> been a better idea to make two different SCN revisions. I can't >>> figure out which changes to test for the dialog routeset checking. >>> >>> >> not the case.... one commit, one fix :) >> >> > That's good, I should have known better. Thanks for the correction, > related RR API addition, and testing as well. Good luck with that. > > Regards, > Brian > > _______________________________________________ > Users mailing list > Users@lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > -- Bogdan-Andrei Iancu www.voice-system.ro _______________________________________________ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users