David/Tijmen/Adrian, It is working for me too. Both inbound and outbound are being recognized and the different rates are being applied. I will keep looking at it while more calls are being made to make sure there are no unforeseen issues.
On Fri, Jan 24, 2014 at 5:35 AM, Tijmen de Mes <tij...@ag-projects.com>wrote: > Hi David, > > Thanks for the patch. If have some time Monday I will analyze it and give > you some feedback so we include this in CDRTool. > > Besides the rating, I’ve to check if the code that now sets the the > ‘route’ for the CDRs and if there are no problems. > > > -- > Tijmen de Mes > AG-Projects > > On 23 januari 2014 at 21:21:26, David M. Lee (d...@digium.com) wrote: > > I’ve got a first attempt at a patch: > https://gist.github.com/leedm777/8585690 > > To get this to work, your CDR’s will have to record the application > subtype. For me, I set $avp(s:call_class) = “audio.inbound” or > “audio.outbound” as appropriate in the routes, and added > Sip-Application-Type=$avp(s:call_class) to “radius_extra”. > > Billing rates will be matched on the full application, allowing > different rates depending on the application subtype. > > It works with the simple testing I’ve been able to do on my desktop. > Feedback, of course, is greatly appreciated. > > Duane - Does the patch work for you? > > Adrian - Any objections/concerns with this approach? > > If it looks good, I’ll work on updating the docs. > > Thanks! > -- > David M. Lee > Digium, Inc. | Software Developer > 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA > Check us out at: www.digium.com & www.asterisk.org > > On Jan 23, 2014, at 4:43 AM, Adrian Georgescu <a...@ag-projects.com> wrote: > > > I think it would be a good idea. > > > > Adrian > > > > On 22 Jan 2014, at 16:58, David Lee (digium) <d...@digium.com> wrote: > > > >> Duane Larson wrote: > >>> I have been playing with CDRTool for a while but I am not sure if it > is > >>> possible to rate Origination (Inbound) calls differently than > Termination > >>> (Outbound) calls from my SIP Provider. For Origination I pay 0.0035 > and > >>> for Termination I pay 0.005. Keep in mind these costs are for > destination > >>> "1”. > >> > >> I've recently run into nearly the same situation. > >> > >> I tried overloading the Sip-Application-Type field, but it's limited > >> by the supportedApplicationTypes array in cdr_generic.php. There also > >> seems to be hard coded logic for the different application types. > >> > >> I think I will patch CDRTool so that you can have subtypes of > >> application types (audio.inbound, audio.outbound, etc.). This would > >> allow the billing rates to be a bit more specific for these > >> situations. > >> > >> Thoughts? > >> -- > >> David M. Lee > >> Digium, Inc. | Software Developer > >> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA > >> Check us out at: www.digium.com & www.asterisk.org > >> _______________________________________________ > >> Users mailing list > >> Users@lists.opensips.org > >> http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > > > _______________________________________________ > > Users mailing list > > Users@lists.opensips.org > > http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > > _______________________________________________ > Users mailing list > Users@lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > > _______________________________________________ > Users mailing list > Users@lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > -- -- *--*--*--*--*--* Duane *--*--*--*--*--* --
_______________________________________________ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users