I made it work !

I join to this mail a cvs patch for jdiff plugin.

It would be a good thing that any maven master take a look at it as I needed to set 
some value using local repository
path : ${user.home}/.maven/repository...


Notice jdiff has a 1.0.9 version that isn't in ibiblio repository.

Nico.



----- Original Message ----- 
From: "Nicolas De Loof" <[EMAIL PROTECTED]>
To: "Maven Users List" <[EMAIL PROTECTED]>
Sent: Thursday, December 18, 2003 4:06 PM
Subject: Re: jdiff plugin


> I made some simple changes in plugin.jelly and jdiff goal now get sources from CVS 
> for the two versions to compare.
>
> But when plugin calls javadoc I get
>
>     [javadoc] Generating Javadoc
>     [javadoc] Javadoc execution
>     [javadoc] javadoc: Cannot find doclet class jdiff.JDiff
>     [javadoc] 1 error
>
>
> I don't know how to set javadoc classpath to include jdiff doclet class. Can someone 
> help me ?
>
> Nico.
>
>
> ----- Original Message ----- 
> From: "Emmanuel Venisse" <[EMAIL PROTECTED]>
> To: "Maven Users List" <[EMAIL PROTECTED]>
> Sent: Thursday, December 18, 2003 3:37 PM
> Subject: Re: jdiff plugin
>
>
> > Apparently, you're the first person that use this plugin since a long time.
> > I think we don't update it when we modify maven apis.
> >
> > If you have a patch, it will be xelcome.
> >
> > Emmanuel
> >
> > ----- Original Message ----- 
> > From: "Nicolas De Loof" <[EMAIL PROTECTED]>
> > To: "Maven Users List" <[EMAIL PROTECTED]>
> > Sent: Thursday, December 18, 2003 3:25 PM
> > Subject: jdiff plugin
> >
> >
> > > Hello all,
> > >
> > > I'm trying to use the jdiff plugin with maven 1.0 RC1
> > >
> > > I got it from CVS and done a "maven plugin:install"
> > >
> > > now, when I use "maven jdiff" I get this error :
> > >
> > > BUILD FAILED
> > > File...... file:/C:/Documents and
> > Settings/ndeloof/.maven/plugins/maven-jdiff-plugin-1.1/
> > > Element... maven:makeRelativePath
> > > Line...... 44
> > > Column.... 120
> > > You must define an attribute called 'path' for this tag.
> > > Total time: 6 seconds
> > > Finished at: Thu Dec 18 15:24:09 CET 2003
> > >
> > >
> > > The line 44 in plugin.jelly is for :
> > >         <maven:makeRelativePath var="mavenRelativeSrcDir"
> > basedir="${basedir}" path="${maven.build.sourceDirectory}" />
> > >
> > > I added some <echo> in plugin.jelly and see that
> > ${maven.build.sourceDirectory} is not set.
> > >
> > > What do I miss ?
> > >
> > >
> > > Nico.
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
Index: plugin.jelly
===================================================================
RCS file: /home/cvspublic/maven-plugins/jdiff/plugin.jelly,v
retrieving revision 1.8
diff -u -r1.8 plugin.jelly
--- plugin.jelly        29 Aug 2003 06:27:52 -0000      1.8
+++ plugin.jelly        18 Dec 2003 15:30:03 -0000
@@ -41,13 +41,12 @@
         <ant:property name="maven.jdiff.new.dir" 
value="${maven.jdiff.dir}/${maven.jdiff.new.tag}"/>  
         <ant:mkdir dir="${maven.jdiff.new.dir}"/>
 
-        <maven:makeRelativePath var="mavenRelativeSrcDir" basedir="${basedir}" 
path="${maven.build.sourceDirectory}" />
         <ant:cvs
           cvsRoot="${pom.repository.cvsRoot}"
           package="${pom.repository.cvsModule}/${mavenRelativeSrcDir}"
           dest="${maven.jdiff.new.dir}"
           tag="${maven.jdiff.new.tag}"
-        />
+        />    
         <ant:property name="maven.jdiff.new.src" 
           
value="${maven.jdiff.new.dir}/${pom.repository.cvsModule}/${relativeSrcDir}"/>
     
@@ -65,7 +64,6 @@
           value="${maven.jdiff.dir}/${maven.jdiff.old.tag}"/>  
         <ant:mkdir dir="${maven.jdiff.old.dir}"/>
 
-        <maven:makeRelativePath var="mavenRelativeSrcDir" basedir="${basedir}" 
path="${maven.build.sourceDirectory}" />
         <ant:cvs
           cvsRoot="${pom.repository.cvsRoot}"
           package="${pom.repository.cvsModule}/${mavenRelativeSrcDir}"
@@ -77,19 +75,17 @@
           
value="${maven.jdiff.old.dir}/${pom.repository.cvsModule}/${relativeSrcDir}"/>
       </j:otherwise>
     </j:choose>
-
     
     <ant:property name="maven.cp.sub" refid="maven-classpath"/>
-    <ant:property name="maven.cp" value="${maven.cp.sub};${java.class.path}"/>
+    <ant:property name="jdiff.jar" 
value="${user.home}/.maven/repository/jdiff/jars/jdiff-1.0.7.jar"/>
+    <ant:property name="maven.cp" 
value="${maven.cp.sub};${jdiff.jar};${java.class.path}"/>
 
     <ant:property name="baseuri" value="${maven.home}/plugins/jdiff"/>
     
     <ant:javadoc 
       sourcepath="${maven.jdiff.old.src}"
-      packagenames="${pom.package}.*"
-      >
-      <ant:doclet name="jdiff.JDiff"
-        path="${maven.cp}">
+      packagenames="${pom.package}.*">
+      <ant:doclet name="jdiff.JDiff" path="${maven.cp}">
         <ant:param name="-apiname" value="${maven.jdiff.old.tag}"/>
         <ant:param name="-baseURI" value="${baseuri}"/>
       </ant:doclet>
@@ -99,8 +95,7 @@
       packagenames="${pom.package}.*"
       sourcepath="${maven.jdiff.new.src}">
       
-      <ant:doclet name="jdiff.JDiff"
-        path="${maven.cp}">
+      <ant:doclet name="jdiff.JDiff" path="${maven.cp}">
         <ant:param name="-apiname" value="${maven.jdiff.new.tag}"/>
         <ant:param name="-baseURI" value="${baseuri}"/>
       </ant:doclet>
@@ -110,8 +105,7 @@
       private="yes"
       destdir="${maven.jdiff.changes.dir}"
       packagenames="${pom.package}.*"
-      sourcepath="${maven.jdiff.new.src}"
-      >
+      sourcepath="${maven.jdiff.new.src}">
 
       <ant:doclet name="jdiff.JDiff" path="${maven.cp}">
         <ant:param name="-stats"/>
@@ -122,11 +116,11 @@
 
     </ant:javadoc> 
     
-    <ant:copy todir="${maven.jdiff.changes.dir}">
-      <ant:fileset dir="${maven.home}/plugins/jdiff-maven-plugin-1.0">
+   <ant:copy todir="${maven.jdiff.changes.dir}">
+      <ant:fileset 
dir="${user.home}/.maven/plugins/maven-jdiff-plugin-1.1/plugin-resources">
         <ant:include name="*.gif"/>
       </ant:fileset>
-    </ant:copy> 
+    </ant:copy>
     
   </goal>
 

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to