Re: optional aspects

[Mark Proctor]

Carlos,
I can put the aspects to compile .aspect files and reference it like below
         <ant:argfiles>
             <pathelement location="trace.aspect"/>
             <pathelement location="event-model.aspect"/>
         </ant:argfiles>
and then updated sourceRoots, as you can't have both - one or the other:
       <ant:sourceroots>
         <ant:path refid="${sourcePathRefid}"/>
         <!--
         <j:if test="${aspectSourcesPresent == 'true'}">
           <ant:pathelement location="${pom.build.aspectSourceDirectory}"/>
         </j:if>
         -->
       </ant:sourceroots>
Downside is you have to create files to specify the aspects, but atleast 
its doable. So I can create a .aspect file for each aspect I want to 
weave. I still need some way to specify those locations as a maven property.
I then need to say if aspects file property is specified then use that, 
else specify ${pom.build.aspectSourceDirectory} in ant:sourceroots as 
normal.

Mark
Carlos Sanchez wrote:
Feel free to CCing your findings to me.
 

-----Original Message-----
From: Mark Proctor [mailto:[EMAIL PROTECTED] 
Sent: Friday, July 30, 2004 5:54 PM
To: Maven Users List
Subject: Re: optional aspects

Just tried testing the plugin with the code change below, but 
that failed, will look into that list option now:

       <ant:sourceroots>
         <ant:path refid="${sourcePathRefid}"/>
         <ant:path>
             <fileset dir="${pom.build.aspectSourceDirectory}">
               <includes>
                 <include name="**/*EventModel.java"/>
                 <include name="**/*Trace.java"/>
                 <include name="**/*EntryMethod.java"/>
               </includes>
             </fileset>
         </ant:path>
         <!--
         <j:if test="${aspectSourcesPresent == 'true'}">
           <ant:pathelement 
location="${pom.build.aspectSourceDirectory}"/>
         </j:if>
         -->
       </ant:sourceroots>
------------
MessageHolder:  (3 error)  (1 fail)  (1 abort)
[error   0]: error build config error: bad sourceroot: 
D:\java\eclipse\workspace
s\drools\drools-core\src\aspects\org\drools\MethodEntry.java
[error   1]: error build config error: bad sourceroot: 
D:\java\eclipse\workspace
s\drools\drools-core\src\aspects\org\drools\reteoo\DroolsEvent
Model.java
[error   2]: error build config error: bad sourceroot: 
D:\java\eclipse\workspace
s\drools\drools-core\src\aspects\org\drools\Trace.java

Carlos Sanchez wrote:
   

Hi,
I suggest you to check this thread on aspectj-users mailing list 
http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg02478.html
titled "POLL: How do you use ".lst" files with AJDT in Eclipse?"
and https://bugs.eclipse.org/bugs/show_bug.cgi?id=50454

The aspectj maven plugin uses iajc ant task, so if you can point out 
something about adding conditional weaving I'll be happy to 
     

add it to 
   

the plugin.
Regards
Carlos Sanchez
A Coruņa, Spain
Oness Project
http://oness.sourceforge.net

     

-----Original Message-----
From: Mark Proctor [mailto:[EMAIL PROTECTED]
Sent: Friday, July 30, 2004 4:29 PM
To: Maven Users List
Subject: optional aspects
We are building up a suite of aspects with aspectj to help with 
testing/debugging. We want to be able to choose which aspects are 
weaved at compile time with property settings, is this possible?

I was hoping I could do:
maven.aspectj.sourceRootCopyFilter=**/drools/Trace.java,
**/drools/Trace/MethodEntry.java
But that is obviously just for resource copying, ideally I 
       

need to be 
   

able to exclude/include aspects.
Mark
------------------------------------------------------------
       

---------
   

To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

  

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

     

   


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]