On Mon, Jul 23, 2012 at 12:50 PM, Wayne Fay <wayne...@gmail.com> wrote: >> everything except what is in the exclude(s). It seems like a bug that >> non-classnames such as string constants are also being sent to the >> relocator. Given every string literal is being relocated, I can't imagine >> a pattern to exclude those. > > How should Shade handle code like Class.forName("java.lang.Thread") > unless it also considers (and thus relocates) string constants?
Since you can also have String foo = "java.lang.Thread"; I don't see how we could add selectivity by class receiving the string. So the only option would be forking the filtering of string constants, and that makes me squeamish. I really think that a more selective <package/> is the way to go here. > > Wayne > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@maven.apache.org > For additional commands, e-mail: users-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org