Where is the ticket in Jira? Last time I meant when Romain improved the plugin a lot. Maybe before you created the ticket. T
On Sun, May 16, 2021 at 1:01 PM Alexander Kriegisch < [email protected]> wrote: > Sorry Tibor, I am not sure which "last time" you are talking about. I > think, last time I interacted with anyone concerning Maven Shade on Jira > was by commenting on an old, existing ticket, getting zero help and then > fixing the problem myself, trying return something to the community by > means of an utterly ignored pull request. Hence, I thought I try a > channel other than Jira and a simple question istead of a PR this time. > It seems to me, whichever way I choose, it is considered to be wrong. > What would you have me do? Open a Jira issue, sending a link to the OSS > project I am working on and which reproduces the mentioned behaviour? > Maybe a screenshot of me "diffing" the two JARs before and after > relocation? I am willing to provide any kind of information which makes > someone engange in investigating and finally answering my question. Just > kindly let me know how to do it right this time. > > > Tibor Digana schrieb am 16.05.2021 17:16 (GMT +07:00): > > > These Apache developers work with Jira based on objective materials > > attached to Jira, like a reproducible project provided by you on Github > or > > a provided POM. > > Then they will take care especially regarding the maven-shade-plugin they > > want to improve this plugin, and there was a big effort given to this > > plugin last time, so I am sure they want to handle the bugs in Jira > again. > > T > > > > On Sun, May 16, 2021 at 4:41 AM Alexander Kriegisch < > > [email protected]> wrote: > > > >> When running Maven Shade with relocation, it works nicely. When > >> comparing JARs before and after relocation, I was surprised to see that > >> Shade not just modifies the relocated classes and classes referencing > >> them, but also a bunch of IMO completely unrelated classes. In my case I > >> am transforming an uber JAR containing ASM, and I selectively relocate > >> the ASM classes, intending to leave all others untouched. I know that > >> ASM classes are referred to by some of the other classes, but by no > >> means as many as are being modified. The byte code is slightly > >> different, probably still does the same thing, but it makes comparisons > >> and sanity checks or automatic verification steps harder than necessary. > >> BTW, the same Shade execution also relocates the sources and really only > >> changes source files referencing ASM, just like I would have expected. > >> > >> Looking forward to your insights > >> -- > >> Alexander Kriegisch > >> https://scrum-master.de > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
