Sounds great. Not trying to force you to do something you don't want
to do, but just thought I'd mention it since it occurred to me.

I don't currently use Jaxb but if/when I do in the future, it might be
nice to know that I'd have to option of jdk4 if I needed to use it.
;-)

And that's how open source software like Maven works best, with users
contributing patches to add functionality the developers have not yet
needed/seen as important...

Wayne


On 3/15/06, Andreas Guther <[EMAIL PROTECTED]> wrote:
> Wayne,
>
> I appreciate your hint and I think you have a valuable point talking
> about contributing back to the community.  I must admit I was thinking
> about contributing the changes but one the other hand I am hesitant
> because what I did is a quick hack and lacks any repeatable tests.
>
> However, the changes are not that huge.  I had to remove some generics
> and utilize a different jaxb driver call.
>
> I am using it internally as Jaxb1 plug-in since it goes with the Jaxb 1
> jars.  I also had to add the missing "-extension" flag handling which I
> believe is a needed fix for the Jaxb2 plug-in.
>
> It would be interesting to merge the code so it can handle both
> versions.  The major change I see is removing the usage Java 5 features.
> Once that is reversed, the only difference I see is in the way to call
> the jaxb driver.
>
> I think it would make less sense to have two different projects since
> the code does only differ in minor parts.
>
> The changes work fine for my purposes.
>
> I guess it would be interesting to talk first to the original
> contributor.  I am not sure about test cases (I could not find any) and
> about the process of contributing the fixes.
>
> But I am definitely open to contribute the changes in one or the other
> form.
>
> Andreas
>
>
>
> -----Original Message-----
> From: Wayne Fay [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, March 15, 2006 2:23 PM
> To: Maven Users List
> Subject: Re: [M2] Project Lifecycle generate-sources -- how compile?
>
> > The plugin only runs with Java 5.  I actually had to change to code to
> > make it work with Java 1.4.
>
> Andreas, I don't suppose you're planning on contributing your changes
> back to the jaxb2 project so others using jdk1.4 could use it instead
> of only the jdk5 people? :-)
>
> Assuming of course that you didn't have to remove some significant
> functionality and its largely equivalent to the jdk5 jaxb2 code...
>
> Or they could perhaps package your code as jaxb2 with a classifier of
> jdk4?
>
> Wayne
>
>
> > -----Original Message-----
> > From: Stephen Duncan [mailto:[EMAIL PROTECTED]
> > Sent: Wednesday, March 15, 2006 3:19 AM
> > To: Maven Users List
> > Subject: Re: [M2] Project Lifecycle generate-sources -- how compile?
> >
> > If you're using the jaxb plugin from mojo:
> > http://mojo.codehaus.org/jaxb2-maven-plugin/ and this is happening,
> > then it's a bug in the plugin, and an issue should be put in JIRA.
> >
> > -Stephen
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

Reply via email to