I don't understand why that test (isExecutionRoot()) is even there to begin with.
Why does that matter? If you're specifying a fileset, isn't it to get rid of stuff outside of the src/target directories? -----Original Message----- From: Martin Gainty [mailto:[EMAIL PROTECTED] Sent: Wednesday, September 17, 2008 11:02 AM To: Maven Users List; [EMAIL PROTECTED] Subject: RE: clean won't delete stuff that isn't in ./target what happens when if ( !project.isExecutionRoot() ) is NOT NULL? why not go ahead and submit your patch.. ? Martin ______________________________________________ Disclaimer and confidentiality note Everything in this e-mail and any attachments relates to the official business of Sender. This transmission is of a confidential nature and Sender does not endorse distribution to any party other than intended recipient. Sender does not necessarily endorse content contained within this transmission. > Subject: RE: clean won't delete stuff that isn't in ./target > Date: Wed, 17 Sep 2008 09:32:02 -0400 > From: [EMAIL PROTECTED] > To: users@maven.apache.org; [EMAIL PROTECTED] > > To all that have replied - > > I tried the exact syntax below and it doesn't work. > > Another part to this is we have a parent -> child -> child pom relation ship, > and the clean target is in the lowest level. Running from the top most > level, clean does not work. > > From my last run, here's what I have in my pom: > > <plugin> > <artifactId>maven-clean-plugin</artifactId> > <version>2.2</version> > <configuration> > <fileset> > <directory>${some.var}/../deleteme</directory> > <directory>C:/full/path/to/deleteme</directory> > </fileset> > <verbose>true</verbose> > </configuration> > </plugin> > Running from the top most level, "deleteme" still lives. > > I've tried every possible combination of <filesets><fileset><directory> but > nothing works. > > Looking at the source for clean, I see this: > > 209 if ( !project.isExecutionRoot() ) > 210 { > 211 String projectBasedir = StringUtils.replace( > project.getBasedir().getAbsolutePath(), > 212 "\\", "/" ); > 213 String filesetDir = StringUtils.replace( > fileset.getDirectory(), "\\", "/" ); > 214 > 215 if ( filesetDir.indexOf( projectBasedir ) == -1 ) > 216 { > 217 fileset.setDirectory( projectBasedir + "/" + filesetDir ); > 218 } > 219 } > 220 > 221 fileSetManager.delete( fileset, failOnError ); > > #1 - How would this block of code ever get executed in my case? > #2 - That second if statement, filesetDir does not contain the project > basedir at all, so this code prepends it to each fileset?! > > I've written a plugin (maven-really-clean) that just takes a series of > directories and using plexus.file utils, deletes them, regardless of where > they are on your system. > > The clean plugin simply does NOT work. > > > -----Original Message----- > From: Karl Heinz Marbaise [mailto:[EMAIL PROTECTED] > Sent: Wednesday, September 17, 2008 5:16 AM > To: Maven Users List > Subject: Re: clean won't delete stuff that isn't in ./target > > Hi there, > you can simply use: > > <configuration> > > <fileset><directory>C:/some/other/dir/deleteme</directory></fileset> > </configuration> > Nothing more... > > And as mentioned...absolute directories are a very bad idea... > > Kind regards > Karl Heinz Marbaise > -- > SoftwareEntwicklung Beratung Schulung Tel.: +49 (0) 2405 / 415 893 > Dipl.Ing.(FH) Karl Heinz Marbaise ICQ#: 135949029 > Hauptstrasse 177 USt.IdNr: DE191347579 > 52146 Würselen http://www.soebes.de > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > _________________________________________________________________ Want to do more with Windows Live? Learn "10 hidden secrets" from Jamie. http://windowslive.com/connect/post/jamiethomson.spaces.live.com-Blog-cns!550F681DAD532637!5295.entry?ocid=TXT_TAGLM_WL_domore_092008 --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
