Thx for the feedback! Would you mind raising a jira issue and attach your patch to it?
On 06/25/2009, pttorgenrud <[email protected]> wrote: > > Hi Guillaume, > > Nice work. Thanks from one user, anyways :) > > I've found a few hours to play with the 0.1.0 version, and I have one small > suggestion, but I wasn't sure if I should file a bug report. > ClientSessionImpl takes SshClient as an argument and passes it to > AbstractSession (which is its super). AbstractSession stores this as > FactoryManager type and it does not seem to be used as SshClient type (thank > goodness) at that level. If the SshClient argument to ClientSessionImpl were > changed to FactoryManager, it would be possible to extend > AbstractFactoryManager as you have for the SshClient class so I can > implement my own custom client functionality and to and re-use > ClientSessionImp, as I assume was your intention. > > I've run the maven assembly:assembly command against a changed copy of the > latest svn, which executes the tests, and they pass. > > Thanks again for your work on this library, > Pete > > > > gnodet-2 wrote: >> >> We're pleased to announce the first release of the Apache Mina SSHD >> project. >> >> Feedback welcome ! >> > > -- > View this message in context: > http://www.nabble.com/-ANNOUNCE--Apache-Mina-SSHD-0.1.0-tp24094160p24194883.html > Sent from the Apache MINA User Forum mailing list archive at Nabble.com. > > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
