Hi Peter,

On Sun, Mar 2, 2014 at 8:31 AM, Peter Rader <[email protected]> wrote:
> Hello.
>
> VcardTempPersistenceManager has a method getVcard results in String.
> The XMPP-vCard itself is in XML-Format but the relevant VcardTempIQHandler
> handle the vCard as a html-escaped text.

How exactly is that a problem?
>From what I can see in the current implementation, the vCard's content
is interpreted as XML all the way

>     To design getVcard returning a String is bad design.

Strings are a neutral transport for XML.
What do you propose?

> I dont like to vote for a redesign of the interface now because a upgrade to
> vysper 0.8 will result in incompatibility for those who already use the
> interface VcardTempPersistenceManager.

Well, incompatibility might at some point be traded for better code.

> I vote for a parsing the resulting String as XML, even if a vCard by RFC6350
> defined a property-key-value-format because the Context of the getter is a
> xmpp-vcard that has more informations a original vcard by RFC6350 may
> contain.

What do you mean by "parsing the resulting String as XML"? The
PersistenceManager might do all that.

> Anyway: The curiousity of some structures like this ban mina from my list of
> usefull projects.

We were talking about Vysper here. Please don't blame the whole MINA
project for this.

  Bernd

Reply via email to