ok, I will handle it, maybe already for 1.0.11.
Thanks for your help.
I am keeping this "testing mode" open for the rest of the week,
so that we can hit the VOTE next week. Which means by
end-of-next-week there should be a 1.0.11 out
-Matthias
On Wed, Aug 26, 2009 at 12:24 PM, Paul Mander<paul.s.man...@gmail.com> wrote:
>
> It appears that this class hasn't changed since the fix was provided. The
> change is to introduce a new method:
>
> private void _renderShowComboBoxScriptForIE6(FacesContext context,
> RenderingContext arc,
> FacesBean bean,
> String baseId) throws IOException
> {
> if ("ie".equals(arc.getAgent().getAgentName()) &&
> arc.getAgent().getAgentVersion().startsWith("6"))
> {
> // IE6 only
> final ResponseWriter writer = context.getResponseWriter();
> final String monthId = (baseId != null) ? baseId +
> ChooseDateRenderer.MONTH_PARAM : ChooseDateRenderer.MONTH_PARAM;
> final String yearId = (baseId != null) ? baseId +
> ChooseDateRenderer.YEAR_PARAM : ChooseDateRenderer.YEAR_PARAM;
>
> writer.startElement("script", null);
> writer.writeAttribute("type", "text/javascript", null);
> writer.writeText("window.onload=showCombo; \n", null);
> writer.writeText("function showCombo() { \n", null);
> // Normal Trinidad onLoad;
> writer.writeText("_checkLoad(); \n", null);
> writer.writeText("document.getElementById('" + monthId + "').style.cssText =
> 'display: inline !important; visibility: visible !important;'; \n", null);
> writer.writeText("document.getElementById('" + yearId + "').style.cssText =
> 'display: inline !important; visibility: visible !important;'; \n", null);
> // ToDo: Resize iframe to remove scrollbars:
> writer.writeText("return true; \n", null);
> writer.writeText("} \n", null);
>
> writer.endElement("script");
> }
>
> }
>
> and call it unconditionally at the very end of encodeAll.
>
> Sorry, but I'm not in a position to to a diff.
>
>
> Matthias Wessendorf-4 wrote:
>>
>>
>> I see - maybe we should make this become part of 1.0.12 ?
>> Question: Can you upload a DIFF ? That makes reviewing much easier,
>> instead
>> of replacing a .java file
>>
>> Thanks!
>> Matthias
>>
>>
>
> --
> View this message in context:
> http://www.nabble.com/-Trinidad--1.0.11-release-candidate---please-test-tp25138955p25150152.html
> Sent from the MyFaces - Users mailing list archive at Nabble.com.
>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
