That’s great. Feel free to provide a pull request on GitHub. What caused the tests to fail, what messages did you get? You should be able to build the module without running the tests, I believe.
Gj On Mon, 15 Apr 2019 at 17:08, Ben Erridge <b...@ciminc.com> wrote: > OK, I have downloaded the module and successfully compiled it. The module > seems to work fine with pretty much the same bugs as in Netbeans 8.2. > I had to comment out test code in a bunch of modules it depends on in > order to get it to compile though. I attached a diff of these files. I also > change some code WLServerLibraryManager because it doesn't work with WLS > 12.2 +. > I'm not sure what to do about these other modules test code not compiling. > Maybe I have a setup issue? I am compiling from the master branch. > > modified: > > java/j2ee.metadata.model.support/test/unit/src/org/netbeans/modules/j2ee/metadata/model/support/PersistenceTestCase.java > modified: > java/java.project.ui/test/qa-functional/src/projects/TestProjectUtils.java > modified: > > java/java.source.base/test/unit/src/org/netbeans/api/java/source/gen/GeneratorTestBase.java > modified: > > java/java.source.base/test/unit/src/org/netbeans/api/java/source/gen/GuardedBlockTest.java > modified: > > java/java.source.base/test/unit/src/org/netbeans/api/java/source/gen/TreeRewriteTestBase.java > modified: > > java/java.source.base/test/unit/src/org/netbeans/modules/java/source/save/FormatingTest.java > modified: > > java/java.source.nbjavac/test/unit/src/org/netbeans/modules/java/source/nbjavac/indexing/ClassNamesForFileOraculumImplTest.java > modified: > > java/java.source.nbjavac/test/unit/src/org/netbeans/modules/java/source/nbjavac/indexing/MultiPassCompileWorkerTest.java > modified: > > java/java.source.nbjavac/test/unit/src/org/netbeans/modules/java/source/nbjavac/indexing/OnePassCompileWorkerTest.java > modified: > > java/java.source.nbjavac/test/unit/src/org/netbeans/modules/java/source/nbjavac/indexing/SuperOnePassCompileWorkerTest.java > modified: > > java/spi.java.hints/test/unit/src/org/netbeans/spi/java/hints/matching/CopyFinderTest.java > > > On Fri, Apr 12, 2019 at 8:51 AM Ben Erridge <b...@ciminc.com> wrote: > >> Thanks, I'll check it out. >> >> On Fri, Apr 12, 2019 at 8:31 AM Geertjan Wielenga <geert...@apache.org> >> wrote: >> >>> That's great to hear. I'm not sure if it's a license issue. You could >>> try to build the module from the GitHub repo and install it and see where >>> that gets you, i.e., whether that works. >>> >>> Gj >>> >>> On Fri, Apr 12, 2019 at 2:27 PM Ben Erridge <b...@ciminc.com> wrote: >>> >>>> I am definitely willing to contribute to coding and testing. Let me >>>> know when you get a chance to resolve the license issue. I will try to take >>>> a moment to look through the code. >>>> >>>> On Fri, Apr 12, 2019 at 1:26 AM Geertjan Wielenga < >>>> geertjan.wiele...@googlemail.com> wrote: >>>> >>>>> The code for the WebLogic support is here: >>>>> >>>>> >>>>> https://github.com/apache/incubator-netbeans/tree/master/enterprise/j2ee.weblogic9 >>>>> >>>>> I am not 100% sure of the status of that part of Apache NetBeans, >>>>> probably there are licensing issues, i.e., probably not everything was >>>>> donated or cannot be released, we'll need to take a look -- are you going >>>>> to be involved in working on this code or trying things out? >>>>> >>>>> Gj >>>>> >>>>> On Fri, Apr 12, 2019 at 12:57 AM Ben Erridge <b...@ciminc.com> wrote: >>>>> >>>>>> Is WebLogic support planned for Apache Netbeans in the future? >>>>>> >>>>>> -- >>>>>> -------------. >>>>>> Ben Erridge >>>>>> Center For Information Management, Inc. >>>>>> office: (734) 930-0855 direct: (734) 800-4354 <%28734%29%20930-0855> >>>>>> 3550 West Liberty Road >>>>>> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g>Ste >>>>>> 1 >>>>>> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >>>>>> Ann Arbor, MI >>>>>> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >>>>>> 48103 >>>>>> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >>>>>> >>>>> >>>> >>>> -- >>>> -------------. >>>> Ben Erridge >>>> Center For Information Management, Inc. >>>> office: (734) 930-0855 direct: (734) 800-4354 <%28734%29%20930-0855> >>>> 3550 West Liberty Road >>>> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g>Ste >>>> 1 >>>> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >>>> Ann Arbor, MI >>>> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >>>> 48103 >>>> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >>>> >>> >> >> -- >> -------------. >> Ben Erridge >> Center For Information Management, Inc. >> office: (734) 930-0855 direct: (734) 800-4354 <%28734%29%20930-0855> >> 3550 West Liberty Road >> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g>Ste >> 1 >> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >> Ann Arbor, MI >> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >> 48103 >> <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> >> > > > -- > -------------. > Ben Erridge > Center For Information Management, Inc. > office: (734) 930-0855 direct: (734) 800-4354 <%28734%29%20930-0855> > 3550 West Liberty Road > <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g>Ste > 1 > <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> > Ann Arbor, MI > <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> > 48103 > <https://maps.google.com/?q=3550+West+Liberty+Road%C2%A0+Ste+1+Ann+Arbor,+MI%C2%A0+48103&entry=gmail&source=g> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org > For additional commands, e-mail: users-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
